From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99F52C4CEC9 for ; Wed, 18 Sep 2019 18:39:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6896E21920 for ; Wed, 18 Sep 2019 18:39:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388872AbfIRSjx (ORCPT ); Wed, 18 Sep 2019 14:39:53 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:54366 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1725899AbfIRSjx (ORCPT ); Wed, 18 Sep 2019 14:39:53 -0400 Received: (qmail 7207 invoked by uid 2102); 18 Sep 2019 14:39:52 -0400 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 18 Sep 2019 14:39:52 -0400 Date: Wed, 18 Sep 2019 14:39:52 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Matthias Maennich cc: linux-kernel@vger.kernel.org, , Greg Kroah-Hartman , Subject: Re: [PATCH v2] usb-storage: SCSI glue: use pr_fmt and pr_err In-Reply-To: <20190918175304.219849-1-maennich@google.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Sep 2019, Matthias Maennich wrote: > Follow common practice and retire printk(KERN_ERR ...) in favor of > pr_fmt and dev_err(). > > Cc: Alan Stern > Cc: Greg Kroah-Hartman > Cc: usb-storage@lists.one-eyed-alien.net > Signed-off-by: Matthias Maennich > --- > drivers/usb/storage/scsiglue.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c > index 6737fab94959..afc4e3221369 100644 > --- a/drivers/usb/storage/scsiglue.c > +++ b/drivers/usb/storage/scsiglue.c > @@ -28,6 +28,8 @@ > * status of a command. > */ > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > + What's this here for? Alan Stern > #include > #include > #include > @@ -379,8 +381,8 @@ static int queuecommand_lck(struct scsi_cmnd *srb, > > /* check for state-transition errors */ > if (us->srb != NULL) { > - printk(KERN_ERR "usb-storage: Error in %s: us->srb = %p\n", > - __func__, us->srb); > + dev_err(&us->pusb_intf->dev, > + "Error in %s: us->srb = %p\n", __func__, us->srb); > return SCSI_MLQUEUE_HOST_BUSY; > } > >