From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81FC4C43331 for ; Fri, 27 Mar 2020 16:36:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C96C206E6 for ; Fri, 27 Mar 2020 16:36:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727833AbgC0QgA (ORCPT ); Fri, 27 Mar 2020 12:36:00 -0400 Received: from netrider.rowland.org ([192.131.102.5]:50777 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727740AbgC0QgA (ORCPT ); Fri, 27 Mar 2020 12:36:00 -0400 Received: (qmail 16971 invoked by uid 500); 27 Mar 2020 12:35:59 -0400 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 27 Mar 2020 12:35:59 -0400 Date: Fri, 27 Mar 2020 12:35:59 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: vladimir.stankovic@displaylink.com cc: gregkh@linuxfoundation.org, , , Subject: Re: [PATCH v4 5/8] usb: mausb_host: Introduce PAL processing In-Reply-To: <20200327152614.26833-6-vladimir.stankovic@displaylink.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Mar 2020 vladimir.stankovic@displaylink.com wrote: > Protocol adaptation layer (PAL) implementation has been added to > introduce MA-USB structures and logic. > > Signed-off-by: Vladimir Stankovic > --- > + /* > + * Masking URB_SHORT_NOT_OK flag as SCSI driver is adding it where it > + * should not, so it is breaking the USB drive on the linux > + */ > + urb->transfer_flags &= ~URB_SHORT_NOT_OK; Please explain more fully. What SCSI driver are you talking about? Where is the flag getting added incorrectly? What USB drive is getting broken, and how? If there's a bug in a SCSI driver, why don't you report it and get it fixed instead of trying to create a workaround in just one host controller driver? Alan Stern