From: Alan Stern <stern@rowland.harvard.edu>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>,
<linux-usb@vger.kernel.org>, Greg KH <gregkh@linuxfoundation.org>,
Corentin Labbe <clabbe@baylibre.com>,
David Howells <dhowells@redhat.com>,
Felipe Balbi <balbi@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: gadget: legacy: fix redundant initialization warnings from cppcheck
Date: Fri, 3 Apr 2020 10:42:48 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.2004031042290.7035-100000@netrider.rowland.org> (raw)
In-Reply-To: <20200403131652.8183-1-masahiroy@kernel.org>
On Fri, 3 Apr 2020, Masahiro Yamada wrote:
> Fix the following cppcheck warnings:
>
> drivers/usb/gadget/legacy/inode.c:1364:8: style: Redundant initialization for 'value'. The initialized value is overwritten$
> value = -EOPNOTSUPP;
> ^
> drivers/usb/gadget/legacy/inode.c:1331:15: note: value is initialized
> int value = -EOPNOTSUPP;
> ^
> drivers/usb/gadget/legacy/inode.c:1364:8: note: value is overwritten
> value = -EOPNOTSUPP;
> ^
> drivers/usb/gadget/legacy/inode.c:1817:8: style: Redundant initialization for 'value'. The initialized value is overwritten$
> value = -EINVAL;
> ^
> drivers/usb/gadget/legacy/inode.c:1787:18: note: value is initialized
> ssize_t value = len, length = len;
> ^
> drivers/usb/gadget/legacy/inode.c:1817:8: note: value is overwritten
> value = -EINVAL;
> ^
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> I do not think this is my fault because the addressed commit did not
> touch this file, but the kbuild test robot sent me this report somehow:
>
> https://lkml.org/lkml/2020/4/3/395
>
> Anyway, the warnings are real, so I removed the redundant assignments.
> I re-ran cppcheck and confirmed the warnings have been fixed.
>
>
> drivers/usb/gadget/legacy/inode.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c
> index aa0de9e35afa..3afddd3bea6e 100644
> --- a/drivers/usb/gadget/legacy/inode.c
> +++ b/drivers/usb/gadget/legacy/inode.c
> @@ -1361,7 +1361,6 @@ gadgetfs_setup (struct usb_gadget *gadget, const struct usb_ctrlrequest *ctrl)
>
> req->buf = dev->rbuf;
> req->context = NULL;
> - value = -EOPNOTSUPP;
> switch (ctrl->bRequest) {
>
> case USB_REQ_GET_DESCRIPTOR:
> @@ -1784,7 +1783,7 @@ static ssize_t
> dev_config (struct file *fd, const char __user *buf, size_t len, loff_t *ptr)
> {
> struct dev_data *dev = fd->private_data;
> - ssize_t value = len, length = len;
> + ssize_t value, length = len;
> unsigned total;
> u32 tag;
> char *kbuf;
Acked-by: Alan Stern <stern@rowland.harvard.edu>
prev parent reply other threads:[~2020-04-03 14:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 13:16 [PATCH] usb: gadget: legacy: fix redundant initialization warnings from cppcheck Masahiro Yamada
2020-04-03 14:42 ` Alan Stern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.2004031042290.7035-100000@netrider.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=balbi@kernel.org \
--cc=clabbe@baylibre.com \
--cc=dhowells@redhat.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).