From: Alan Stern <stern@rowland.harvard.edu>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Qais Yousef <qais.yousef@arm.com>,
USB list <linux-usb@vger.kernel.org>,
Linux-pm mailing list <linux-pm@vger.kernel.org>,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: lockdep warning in urb.c:363 usb_submit_urb
Date: Fri, 17 Apr 2020 19:37:36 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.2004171928160.13245-100000@netrider.rowland.org> (raw)
In-Reply-To: <3462492.idEHzggvYf@kreacher>
On Fri, 17 Apr 2020, Rafael J. Wysocki wrote:
> There is one detail here that I missed, sorry about that.
>
> Actually, the core can only set the runtime status to "active" for
> devices where dev_pm_skip_suspend() returns 'true'.
>
> First, if the device is not "suspended", its status is "active" already
> anyway.
>
> Second, if the device has SMART_SUSPEND clear, the driver may not expect
> its runtime status to change from "suspended" to "active" during system-wide
> resume-type transitions (the driver's system-wide PM callbacks may use
> the runtime status to determine what to do and changing the status this
> way may confuse that).
>
> [Actually, the drivers that set neither SMART_SUSPEND nor MAY_SKIP_RESUME
> may not expect the runtime status to change during system-wide resume-type
> transitions at all, but there is the corner case when the driver can set
> MAY_SKIP_RESUME without setting SMART_SUSPEND. In that case its "noirq"
> and "early" resume callbacks may be skipped and then it should expect
> the runtime status to sometimes change from "active" to "suspended" during
> RESUME transitions, but it may still not expect to see changes the other way
> around, as in that case all of its callbacks are going to be invoked and
> apply the internal runtime status handling mentioned above.]
>
> So overall:
>
> At the start of the {resume,thaw,restore}_noirq phase, if
> dev_pm_skip_resume() returns true ,then the core will set the
> runtime status to "suspended". Otherwise, if dev_pm_skip_suspend()
> also returns true, then the core will set the runtime status to "active".
> If this is not what the subsystem or driver wants, it must update the
> runtime status itself.
Sigh. The bug which prompted this whole thread was when I forgot to
set the runtime PM status back to "active" in one of my drivers. I was
hoping the core could handle it for me automatically.
I guess the answer is always to set the SMART_SUSPEND flag.
> > > > For this to work properly, we will have to rely on subsystems/drivers
> > > > to call pm_runtime_resume() during the suspend/freeze transition if
> > > > SMART_SUSPEND is clear.
> > >
> > > That has been the case forever, though.
> >
> > I'm not so sure about that. The existing PM core code doesn't ever get
> > into a situation where it tries to set a device's runtime status to
> > "active" while the parent's status is "suspended".
>
> I'm assuming that you refer to the scenario below.
>
> > > > Otherwise we could have the following scenario:
> > > >
> > > > Device A has a child B, and both are runtime suspended when hibernation
> > > > starts. Suppose that the SMART_SUSPEND flag is set for A but not for
> > > > B, and suppose that B's subsystem/driver neglects to call
> > > > pm_runtime_resume() during the FREEZE transition. Then during the THAW
> > > > transition, dev_pm_skip_resume() will return "true" for A and "false"
> > > > for B. This will lead to an error when the core tries to set B's
> > > > runtime status to "active" while A's status is "suspended".
>
> That cannot happen, because dev_pm_smart_suspend() also returns 'false' for B
> and so its runtime status will not be changed to "active".
Yes, your change to dev_pm_skip_resume() will prevent the problem from
arising.
> BTW, I have updated my pm-sleep-core branch to reflect what appears to be
> the current state-of-the-art to me.
>
> I'm going to post a v2 of this patch series over the weekend for reference.
Okay, I'll check it out.
By the way, if you don't mind I may want to do some editing of
devices.rst.
Alan Stern
next prev parent reply other threads:[~2020-04-17 23:37 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 14:38 lockdep warning in urb.c:363 usb_submit_urb Qais Yousef
2020-03-23 15:36 ` Oliver Neukum
2020-03-23 15:54 ` Alan Stern
2020-03-23 16:02 ` Qais Yousef
2020-03-23 16:18 ` Oliver Neukum
2020-03-23 15:57 ` Qais Yousef
2020-03-23 16:20 ` Oliver Neukum
2020-03-23 17:29 ` Qais Yousef
2020-03-24 9:08 ` Oliver Neukum
2020-03-24 10:46 ` Qais Yousef
2020-03-24 13:20 ` Oliver Neukum
2020-03-24 13:43 ` Qais Yousef
2020-03-24 13:52 ` Alan Stern
2020-03-24 14:06 ` Qais Yousef
2020-03-24 15:56 ` Alan Stern
2020-03-24 17:22 ` Qais Yousef
2020-03-24 19:22 ` Alan Stern
2020-03-25 15:00 ` Qais Yousef
2020-03-25 20:49 ` Alan Stern
2020-03-25 21:28 ` Rafael J. Wysocki
2020-03-26 12:27 ` Qais Yousef
2020-03-27 20:45 ` Alan Stern
2020-03-28 14:15 ` Rafael J. Wysocki
2020-03-28 19:58 ` Alan Stern
2020-03-29 9:16 ` Rafael J. Wysocki
2020-03-29 13:56 ` Rafael J. Wysocki
2020-03-29 16:27 ` Alan Stern
2020-04-03 15:04 ` Rafael J. Wysocki
2020-04-03 16:13 ` Rafael J. Wysocki
2020-04-03 16:41 ` Alan Stern
2020-04-03 18:32 ` Rafael J. Wysocki
2020-04-03 20:15 ` Alan Stern
2020-04-06 16:45 ` Rafael J. Wysocki
2020-04-06 20:25 ` Alan Stern
2020-04-09 18:45 ` Rafael J. Wysocki
2020-04-11 2:41 ` Alan Stern
2020-04-13 21:32 ` Rafael J. Wysocki
2020-04-14 13:43 ` Rafael J. Wysocki
2020-04-14 17:47 ` Alan Stern
2020-04-15 22:20 ` Rafael J. Wysocki
2020-04-16 15:18 ` Alan Stern
2020-04-17 9:57 ` Rafael J. Wysocki
2020-04-17 16:10 ` Alan Stern
2020-04-17 21:54 ` Rafael J. Wysocki
2020-04-17 23:37 ` Alan Stern [this message]
2020-04-18 9:40 ` Rafael J. Wysocki
2020-04-03 17:08 ` Rafael J. Wysocki
2020-04-20 20:26 ` Alan Stern
2020-04-21 11:15 ` Qais Yousef
2020-03-24 13:47 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.2004171928160.13245-100000@netrider.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=qais.yousef@arm.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).