linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zwane Mwaikambo <zwane@linuxpower.ca>
To: Ted.Wen@ite.com.tw
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ITE_887x parport and serial driver
Date: Tue, 27 May 2003 05:03:00 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.50.0305270430471.2265-100000@montezuma.mastecende.com> (raw)
In-Reply-To: <DC62C613C2F7274C9D361EA476413476392C25@itemail1.internal.ite.com.tw>

On Tue, 27 May 2003 Ted.Wen@ite.com.tw wrote:

> --- parport_serial.c	2002-08-03 08:39:44.000000000 +0800
> +++ parport_serial_887x.c	2003-05-27 14:25:49.000000000 +0800
> @@ -29,8 +29,160 @@
>  
>  #include <asm/serial.h>
>  
> +// ITE8872 ITE8872

I don't mean to nitpick, but please use normal C (I know they are valid 
C99) comments.

> +int ite8872parportnum,ite8872comnum,ITEBOARDNUMBER;
> +u32 ITE8872_INTC[8];
> +u8 ITE8872_IRQ[8];
> +
> +void ite8872_requestirq(int irq,void *dev_id,struct pt_regs *regs){

For 2.5 there is now a return value for interrupt handlers (irqreturn_t)

> +	result = request_irq(ITE8872_IRQ[ITEBOARDNUMBER],ite8872_requestirq,SA_SHIRQ,"ite8872",pcidev);

Which PCI device function is this for?

> +if ((dev->vendor==0x1283 && dev->device==0x8872) && ite8872comnum == 0)
> +return 0;
>        priv->ser = *board;
>        if (board->init_fn && ((board->init_fn) (dev, board, 1) != 0))
>                return 1;
> @@ -308,6 +466,8 @@
>            cards[i].preinit_hook (dev, PARPORT_IRQ_NONE, PARPORT_DMA_NONE))
>                return -ENODEV;
>
> +if ((dev->vendor==0x1283 && dev->device==0x8872) && ite8872parportnum == 0)
> +return 0;
>        for (n = 0; n < cards[i].numports; n++) {
>                struct parport *port;
>                int lo = cards[i].addr[n].lo;

These exceptions look really ugly, how come you need a custom interrupt 
handler?

	Zwane
-- 
function.linuxpower.ca

      reply	other threads:[~2003-05-27  9:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-27  7:06 Ted.Wen
2003-05-27  9:03 ` Zwane Mwaikambo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.50.0305270430471.2265-100000@montezuma.mastecende.com \
    --to=zwane@linuxpower.ca \
    --cc=Ted.Wen@ite.com.tw \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] ITE_887x parport and serial driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).