From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S262478AbTDYUQB (ORCPT <rfc822;willy@w.ods.org>);
	Fri, 25 Apr 2003 16:16:01 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263347AbTDYUQB
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 25 Apr 2003 16:16:01 -0400
Received: from dns.toxicfilms.tv ([150.254.37.24]:50859 "EHLO
	dns.toxicfilms.tv") by vger.kernel.org with ESMTP id S262478AbTDYUQA
	(ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 25 Apr 2003 16:16:00 -0400
Date: Fri, 25 Apr 2003 22:28:05 +0200 (CEST)
From: Maciej Soltysiak <solt@dns.toxicfilms.tv>
To: =?ISO-8859-1?Q?xos=E9_v=E1zquez_p=E9rez?= <xose@wanadoo.es>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [ Compile Regression on i386 ]-2.4.21-rc1 general summary
In-Reply-To: <3EA98CBD.6070106@wanadoo.es>
Message-ID: <Pine.LNX.4.51.0304252226340.15943@dns.toxicfilms.tv>
References: <3EA98CBD.6070106@wanadoo.es>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

> Warning List:
>
> agpgart_be.c:2453: warning: assignment from incompatible pointer type
> agpgart_be.c:2454: warning: assignment from incompatible pointer type
> agpgart_be.c:2480: warning: assignment from incompatible pointer type
> agpgart_be.c:2481: warning: assignment from incompatible pointer type
> agpgart_be.c:3562: warning: assignment from incompatible pointer type
> agpgart_be.c:3563: warning: assignment from incompatible pointer type
> agpgart_be.c:3591: warning: assignment from incompatible pointer type
> agpgart_be.c:3592: warning: assignment from incompatible pointer type
> agpgart_be.c:580: warning: assignment from incompatible pointer type
I remember sending a patch for that 2.4.21pre7 time. Here it is.

Regards,
Maciej Soltysiak

diff -Nru linux-2.4.20.orig/drivers/char/agp/agpgart_be.c linux-2.4.20/drivers/char/agp/agpgart_be.c
--- linux-2.4.20.orig/drivers/char/agp/agpgart_be.c	2003-04-05 17:02:17.000000000 +0200
+++ linux-2.4.20/drivers/char/agp/agpgart_be.c	2003-04-05 17:19:07.000000000 +0200
@@ -577,7 +577,7 @@
 	for (page = virt_to_page(table); page <= virt_to_page(table_end); page++)
 		SetPageReserved(page);

-	agp_bridge.gatt_table_real = (unsigned long *) table;
+	agp_bridge.gatt_table_real = (u32 *) table;
 	agp_gatt_table = (void *)table;
 #ifdef CONFIG_X86
 	err = change_page_attr(virt_to_page(table), 1<<page_order, PAGE_KERNEL_NOCACHE);
@@ -2315,8 +2315,8 @@
 #ifdef CONFIG_AGP_AMD

 typedef struct _amd_page_map {
-	unsigned long *real;
-	unsigned long *remapped;
+	u32 *real;
+	u32 *remapped;
 } amd_page_map;

 static struct _amd_irongate_private {
@@ -2330,7 +2330,7 @@
 	int i;
 	int err = 0;

-	page_map->real = (unsigned long *) __get_free_page(GFP_KERNEL);
+	page_map->real = (u32 *) __get_free_page(GFP_KERNEL);
 	if (page_map->real == NULL) {
 		return -ENOMEM;
 	}
@@ -2590,7 +2590,7 @@
 			     off_t pg_start, int type)
 {
 	int i, j, num_entries;
-	unsigned long *cur_gatt;
+	u32 *cur_gatt;
 	unsigned long addr;

 	num_entries = A_SIZE_LVL2(agp_bridge.current_size)->num_entries;
@@ -2631,7 +2631,7 @@
 			     int type)
 {
 	int i;
-	unsigned long *cur_gatt;
+	u32 *cur_gatt;
 	unsigned long addr;

 	if (type != 0 || mem->type != 0) {