From: Zwane Mwaikambo <zwane@linuxpower.ca>
To: Andrew Morton <akpm@osdl.org>
Cc: Dmitry Torokhov <dtor_core@ameritech.net>,
linux-kernel@vger.kernel.org, vojtech@suse.cz
Subject: Re: [PATCH 2.6] 2/3 Serio: possible race in handle_events
Date: Sat, 23 Aug 2003 07:41:03 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.53.0308230739290.15935@montezuma.fsmlabs.com> (raw)
In-Reply-To: <20030823003447.24aa1efc.akpm@osdl.org>
On Sat, 23 Aug 2003, Andrew Morton wrote:
> Dmitry Torokhov <dtor_core@ameritech.net> wrote:
> >
> > Do you think we should introduce allocate_serio/free_serio pair for dynamically
> > allocated serios; free_serio would scan event_list and invalidate events that
> > refer to freed serio?
>
> I don't understand the subsystem well enough to say. But if we are
> receiving events which refer to an already-freed serio then something is
> very broken. We should be draining all those events before allowing the
> original object to be freed up.
>
> Let's wait for Vojtech's comments.
This sounds somewhat like;
http://bugzilla.kernel.org/show_bug.cgi?id=973
Jul 25 04:54:24 lap kernel: slab error in cache_free_debugcheck(): cache
`size-32': double free, or memory before object was overwritten
Jul 25 04:54:24 lap kernel: Call Trace:
Jul 25 04:54:24 lap kernel: [<c014f130>] kfree+0xf0/0x310
Jul 25 04:54:24 lap kernel: [<c02540fc>] psmouse_disconnect+0x2c/0x40
Jul 25 04:54:24 lap kernel: [<c02540fc>] psmouse_disconnect+0x2c/0x40
Jul 25 04:54:24 lap kernel: [<c025560d>] serio_handle_events+0xad/0xc0
Jul 25 04:54:24 lap kernel: [<c0255620>] serio_thread+0x0/0x100
Jul 25 04:54:24 lap kernel: [<c0255665>] serio_thread+0x45/0x100
Jul 25 04:54:24 lap kernel: [<c010a126>] work_resched+0x5/0x16
Jul 25 04:54:24 lap kernel: [<c0255620>] serio_thread+0x0/0x100
Jul 25 04:54:24 lap kernel: [<c0255620>] serio_thread+0x0/0x100
Jul 25 04:54:24 lap kernel: [<c01073b9>] kernel_thread_helper+0x5/0xc
Jul 25 04:54:24 lap kernel:
Jul 25 04:54:24 lap kernel: slab error in cache_free_debugcheck(): cache
`size-32': double free, or memory after object was overwritten
Jul 25 04:54:24 lap kernel: Call Trace:
Jul 25 04:54:24 lap kernel: [<c014f15e>] kfree+0x11e/0x310
Jul 25 04:54:24 lap kernel: [<c02540fc>] psmouse_disconnect+0x2c/0x40
Jul 25 04:54:24 lap kernel: [<c02540fc>] psmouse_disconnect+0x2c/0x40
Jul 25 04:54:24 lap kernel: [<c025560d>] serio_handle_events+0xad/0xc0
Jul 25 04:54:24 lap kernel: [<c0255620>] serio_thread+0x0/0x100
Jul 25 04:54:24 lap kernel: [<c0255665>] serio_thread+0x45/0x100
Jul 25 04:54:24 lap kernel: [<c010a126>] work_resched+0x5/0x16
Jul 25 04:54:24 lap kernel: [<c0255620>] serio_thread+0x0/0x100
Jul 25 04:54:24 lap kernel: [<c0255620>] serio_thread+0x0/0x100
Jul 25 04:54:24 lap kernel: [<c01073b9>] kernel_thread_helper+0x5/0xc
Jul 25 04:54:24 lap kernel:
next prev parent reply other threads:[~2003-08-23 13:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-23 6:31 [PATCH 2.6] 2/3 Serio: possible race in handle_events Dmitry Torokhov
2003-08-23 7:00 ` Andrew Morton
[not found] ` <200308230206.25142.dtor_core@ameritech.net>
2003-08-23 7:19 ` Andrew Morton
2003-08-23 7:25 ` Dmitry Torokhov
2003-08-23 7:34 ` Andrew Morton
2003-08-23 11:41 ` Zwane Mwaikambo [this message]
2003-08-23 21:42 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.53.0308230739290.15935@montezuma.fsmlabs.com \
--to=zwane@linuxpower.ca \
--cc=akpm@osdl.org \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).