* [TRIVIAL PATCH] sync_dquots_dev in Linux 2.4.21-pre7-ac1
@ 2003-04-15 16:28 Pavel Roskin
2003-04-16 12:28 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Roskin @ 2003-04-15 16:28 UTC (permalink / raw)
To: linux-kernel; +Cc: Alan Cox
Hello!
I'm get this error if I compile 2.4.21-pre7-ac1 without CONFIG_QUOTA
defined:
fs/fs.o: In function `do_quotactl':
fs/fs.o(.text+0x1b362): undefined reference to `sync_dquots_dev'
make: *** [vmlinux] Error 1
sync_dquots_dev() is only implemented if CONFIG_QUOTA is defined.
However, quote.c uses it unconditionally. include/linux/quotaops.h has
some macros to disable some functions when CONFIG_QUOTA is undefined, so
it's probably where the fix belongs. This patch helps:
==============================
--- linux.orig/include/linux/quotaops.h
+++ linux/include/linux/quotaops.h
@@ -193,6 +193,7 @@
#define DQUOT_SYNC_SB(sb) do { } while(0)
#define DQUOT_OFF(sb) do { } while(0)
#define DQUOT_TRANSFER(inode, iattr) (0)
+#define sync_dquots_dev(dev, type) do { } while(0)
extern __inline__ int DQUOT_PREALLOC_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
{
lock_kernel();
==============================
--
Regards,
Pavel Roskin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [TRIVIAL PATCH] sync_dquots_dev in Linux 2.4.21-pre7-ac1
2003-04-15 16:28 [TRIVIAL PATCH] sync_dquots_dev in Linux 2.4.21-pre7-ac1 Pavel Roskin
@ 2003-04-16 12:28 ` Jan Kara
2003-04-28 18:10 ` Pavel Roskin
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kara @ 2003-04-16 12:28 UTC (permalink / raw)
To: Pavel Roskin; +Cc: linux-kernel, Alan Cox
> sync_dquots_dev() is only implemented if CONFIG_QUOTA is defined.
> However, quote.c uses it unconditionally. include/linux/quotaops.h has
> some macros to disable some functions when CONFIG_QUOTA is undefined, so
> it's probably where the fix belongs. This patch helps:
>
> ==============================
> --- linux.orig/include/linux/quotaops.h
> +++ linux/include/linux/quotaops.h
> @@ -193,6 +193,7 @@
> #define DQUOT_SYNC_SB(sb) do { } while(0)
> #define DQUOT_OFF(sb) do { } while(0)
> #define DQUOT_TRANSFER(inode, iattr) (0)
> +#define sync_dquots_dev(dev, type) do { } while(0)
> extern __inline__ int DQUOT_PREALLOC_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
> {
> lock_kernel();
> ==============================
Oops... Yes. Please apply the patch Alan.
Thanks
Honza
--
Jan Kara <jack@suse.cz>
SuSE CR Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [TRIVIAL PATCH] sync_dquots_dev in Linux 2.4.21-pre7-ac1
2003-04-16 12:28 ` Jan Kara
@ 2003-04-28 18:10 ` Pavel Roskin
0 siblings, 0 replies; 3+ messages in thread
From: Pavel Roskin @ 2003-04-28 18:10 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-kernel, Alan Cox
[-- Attachment #1: Type: TEXT/PLAIN, Size: 547 bytes --]
On Wed, 16 Apr 2003, Jan Kara wrote:
> > sync_dquots_dev() is only implemented if CONFIG_QUOTA is defined.
> > However, quote.c uses it unconditionally. include/linux/quotaops.h has
> > some macros to disable some functions when CONFIG_QUOTA is undefined, so
> > it's probably where the fix belongs. This patch helps:
[snip]
> > +#define sync_dquots_dev(dev, type) do { } while(0)
My patch was misapplied. Patch against 2.4.21-rc1-ac2 is attached.
And by the way, Linux 2.4.21-rc1-ac2 calls itself 2.4.21-rc1-ac1.
--
Regards,
Pavel Roskin
[-- Attachment #2: Type: TEXT/PLAIN, Size: 449 bytes --]
--- linux.orig/include/linux/quotaops.h
+++ linux/include/linux/quotaops.h
@@ -193,7 +193,7 @@
#define DQUOT_SYNC_SB(sb) do { } while(0)
#define DQUOT_OFF(sb) do { } while(0)
#define DQUOT_TRANSFER(inode, iattr) (0)
-#define sync_dquotes_dev(dev, type) do { } while(0)
+#define sync_dquots_dev(dev, type) do { } while(0)
extern __inline__ int DQUOT_PREALLOC_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
{
lock_kernel();
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-04-28 17:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-04-15 16:28 [TRIVIAL PATCH] sync_dquots_dev in Linux 2.4.21-pre7-ac1 Pavel Roskin
2003-04-16 12:28 ` Jan Kara
2003-04-28 18:10 ` Pavel Roskin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).