From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S270817AbTGNUNR (ORCPT ); Mon, 14 Jul 2003 16:13:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S270796AbTGNUIa (ORCPT ); Mon, 14 Jul 2003 16:08:30 -0400 Received: from perninha.conectiva.com.br ([200.250.58.156]:50326 "EHLO perninha.conectiva.com.br") by vger.kernel.org with ESMTP id S270794AbTGNUE4 (ORCPT ); Mon, 14 Jul 2003 16:04:56 -0400 Date: Mon, 14 Jul 2003 17:17:16 -0300 (BRT) From: Marcelo Tosatti X-X-Sender: marcelo@freak.distro.conectiva To: Andrea Arcangeli Cc: Jens Axboe , Chris Mason , lkml , "Stephen C. Tweedie" , Alan Cox , Jeff Garzik , Andrew Morton , Alexander Viro Subject: Re: RFC on io-stalls patch In-Reply-To: <20030714201637.GQ16313@dualathlon.random> Message-ID: References: <20030710135747.GT825@suse.de> <1057932804.13313.58.camel@tiny.suse.com> <20030712073710.GK843@suse.de> <1058034751.13318.95.camel@tiny.suse.com> <20030713090116.GU843@suse.de> <20030713191921.GI16313@dualathlon.random> <20030714054918.GD843@suse.de> <20030714131206.GJ833@suse.de> <20030714195138.GX833@suse.de> <20030714201637.GQ16313@dualathlon.random> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 14 Jul 2003, Andrea Arcangeli wrote: > On Mon, Jul 14, 2003 at 09:51:39PM +0200, Jens Axboe wrote: > > - rl = &q->rq; > > - if (!list_empty(&rl->free) && !blk_oversized_queue(q)) { > > + if ((rw == WRITE) && (blk_oversized_queue(q) || (rl->count < 4))) > > did you disable the oversized queue check completely for reads? This > looks unsafe, you can end with loads of ram locked up this way, the > request queue cannot be limited in requests anymore. this isn't the > "request reservation", this a "nearly unlimited amount of ram locked in > for reads". > > Of course, the more reads can be in the queue, the less the background > write loads will hurt parallel apps like a kernel compile as shown in > xtar_load. > > This is very different from the schedule advantage provided by the old > queue model. If you allow an unlimited I/O queue for reads, that means > the I/O queues will be filled by an huge amount of reads and a few > writes (no matter how fast the xtar_load is writing to disk). > > In the past (2.4.22pre4) the I/O queue would been at most 50/50, with > your patch it can be 90/10, hence it can generate an huge performance > difference, that can penealize tremendously the writers in server loads > using fsync plus it can hurt the VM badly if all ram is locked up by > parallel reads. Of course contest mostly cares about reads, not writes. > > Overall I think your patch is unsafe and shouldn't be applied. > > Still if you want to allow 50/50, go ahead, that logic in pre4 was an > order of magnitude more fair and generic than this patch. Well, I change my mind and wont apply it as-is in -pre6.