From: Alex Goddard <agoddard@purdue.edu>
To: Florin Iucha <florin@iucha.net>
Cc: Greg KH <greg@kroah.com>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.5.73
Date: Sun, 22 Jun 2003 16:58:19 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.56.0306221651470.16614@dust.p68.rivermarket.wintek.com> (raw)
In-Reply-To: <Pine.LNX.4.56.0306221615230.11747@dust>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 817 bytes --]
On Sun, 22 Jun 2003, Alex Goddard wrote:
> On Sun, 22 Jun 2003, Florin Iucha wrote:
>
> > drivers/built-in.o(.text+0x3106): In function `pci_remove_bus_device':
> > : undefined reference to `pci_destroy_dev'
> >
> > pci_destroy_dev is defined under CONFIG_HOTPLUG and used outside.
> >
> > florin
> >
> > PS: I think changeset referenced in 10560659712069@kroah.com
> > causes the problem.
>
> An attempt at a fix. It just moves pci_desroy_dev outside the #ifdef).
> I have no idea if this is the correct way to fix this. It compiles okay.
Ack. Dumb-assed mistake in that one. This one shouldn't die during
compile if CONFIG_HOTPLUG is turned on. The other one defined
pci_destroy_dev() twice because I'm dumb.
It does compile (with and without hotplug) and boot.
--
Alex Goddard
agoddard@purdue.edu
[-- Attachment #2: Type: TEXT/PLAIN, Size: 1743 bytes --]
--- hotplug.c.orig 2003-06-22 16:00:25.000000000 -0500
+++ hotplug.c 2003-06-22 16:54:33.000000000 -0500
@@ -11,6 +11,7 @@
#endif
static void pci_free_resources(struct pci_dev *dev);
+static void pci_destroy_dev(struct pci_dev *dev);
#ifdef CONFIG_HOTPLUG
int pci_hotplug (struct device *dev, char **envp, int num_envp,
@@ -173,24 +174,6 @@ int pci_visit_dev (struct pci_visit *fn,
}
EXPORT_SYMBOL(pci_visit_dev);
-static void pci_destroy_dev(struct pci_dev *dev)
-{
- pci_proc_detach_device(dev);
- device_unregister(&dev->dev);
-
- /* Remove the device from the device lists, and prevent any further
- * list accesses from this device */
- spin_lock(&pci_bus_lock);
- list_del(&dev->bus_list);
- list_del(&dev->global_list);
- dev->bus_list.next = dev->bus_list.prev = NULL;
- dev->global_list.next = dev->global_list.prev = NULL;
- spin_unlock(&pci_bus_lock);
-
- pci_free_resources(dev);
- pci_dev_put(dev);
-}
-
/**
* pci_remove_device_safe - remove an unused hotplug device
* @dev: the device to remove
@@ -219,6 +202,24 @@ int pci_hotplug (struct device *dev, cha
#endif /* CONFIG_HOTPLUG */
+static void pci_destroy_dev(struct pci_dev *dev)
+{
+ pci_proc_detach_device(dev);
+ device_unregister(&dev->dev);
+
+ /* Remove the device from the device lists, and prevent any further
+ * list accesses from this device */
+ spin_lock(&pci_bus_lock);
+ list_del(&dev->bus_list);
+ list_del(&dev->global_list);
+ dev->bus_list.next = dev->bus_list.prev = NULL;
+ dev->global_list.next = dev->global_list.prev = NULL;
+ spin_unlock(&pci_bus_lock);
+
+ pci_free_resources(dev);
+ pci_dev_put(dev);
+}
+
static void
pci_free_resources(struct pci_dev *dev)
{
next prev parent reply other threads:[~2003-06-22 21:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-22 18:53 Linux 2.5.73 Linus Torvalds
2003-06-22 20:06 ` Alex Goddard
2003-06-22 20:15 ` Andrew Morton
2003-06-22 22:53 ` Greg KH
2003-06-22 23:31 ` Andrew Morton
2003-06-22 20:46 ` Florin Iucha
2003-06-22 21:17 ` Alex Goddard
2003-06-22 21:45 ` Alex Goddard
2003-06-22 21:58 ` Alex Goddard [this message]
2003-06-23 2:52 ` Greg KH
2003-06-22 23:44 ` 2.5.73: ALSA ISA pnp_init_resource_table compile errors Adrian Bunk
2003-06-23 0:08 ` Adam Belay
2003-07-03 2:53 ` Adrian Bunk
2003-07-03 19:03 ` Adam Belay
2003-07-04 12:11 ` Adrian Bunk
2003-07-15 22:47 ` Adam Belay
2003-07-16 18:22 ` Adrian Bunk
2003-07-16 18:43 ` Adam Belay
2003-07-19 22:03 ` Adrian Bunk
2003-07-20 5:59 ` Jochen Hein
2003-08-09 20:40 ` Adrian Bunk
2003-06-23 0:31 ` 2.5.73: acorn.c compile error Adrian Bunk
2003-06-23 10:13 ` Linux 2.5.73 - Won't compile using oldconfig - config attached vlad
2003-07-02 14:31 ` John Covici
2003-07-02 16:38 ` Greg KH
2003-06-23 20:32 ` Linux 2.5.73 - keyboard failure, repost no. 3 Terje Fåberg
2003-06-26 20:45 ` Vojtech Pavlik
2003-06-27 14:22 ` Terje Fåberg
2003-06-27 19:03 ` Vojtech Pavlik
2003-06-28 9:11 ` Terje Fåberg
2003-06-28 9:37 ` Vojtech Pavlik
2003-06-28 11:40 ` Terje Fåberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.56.0306221651470.16614@dust.p68.rivermarket.wintek.com \
--to=agoddard@purdue.edu \
--cc=florin@iucha.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).