linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mihai RUSU <dizzy@roedu.net>
To: Felipe Alfaro Solana <felipe_alfaro@linuxmail.org>
Cc: acpi-devel@lists.sourceforge.net,
	Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] enhanced psxface.c error handling
Date: Thu, 4 Dec 2003 18:14:06 +0200 (EET)	[thread overview]
Message-ID: <Pine.LNX.4.56L0.0312041813010.8695@ahriman.bucharest.roedu.net> (raw)
In-Reply-To: <1070553752.14488.4.camel@glass.felipe-alfaro.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi

I think you missed the order on this one

@@ -142,14 +143,15 @@
        walk_state = acpi_ds_create_walk_state (obj_desc->method.owning_id,
                           NULL, NULL, NULL);
        if (!walk_state) {
- -               return_ACPI_STATUS (AE_NO_MEMORY);
+               goto acpi_psx_parse_unref;
+               status = AE_NO_MEMORY;
        }

:)

On Thu, 4 Dec 2003, Felipe Alfaro Solana wrote:

> Hi!
> 
> This patch tries to fix the situation where an error could cause
> acpi_psx_execute() to exit without releasing held references to the
> elements of param[].
> 
> Thanks!
> 

- -- 
Mihai RUSU                                    Email: dizzy@roedu.net
GPG : http://dizzy.roedu.net/dizzy-gpg.txt    WWW: http://dizzy.roedu.net
                       "Linux is obsolete" -- AST
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQE/z11QPZzOzrZY/1QRAriPAJ9tJ9A+l1VVCkvxVp5xKcl29+vnBwCguemq
B4+AFaGmaYPah7YgNObfbk4=
=6Nay
-----END PGP SIGNATURE-----

  reply	other threads:[~2003-12-04 16:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-04 16:02 [RFC] enhanced psxface.c error handling Felipe Alfaro Solana
2003-12-04 16:14 ` Mihai RUSU [this message]
2003-12-04 22:00   ` Felipe Alfaro Solana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.56L0.0312041813010.8695@ahriman.bucharest.roedu.net \
    --to=dizzy@roedu.net \
    --cc=acpi-devel@lists.sourceforge.net \
    --cc=felipe_alfaro@linuxmail.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).