From: Linus Torvalds <torvalds@osdl.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Reproducable OOPS with MD RAID-5 on 2.6.0-test11
Date: Thu, 4 Dec 2003 13:06:51 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.58.0312041304120.6638@home.osdl.org> (raw)
In-Reply-To: <E1AS0TP-0003ga-00@gondolin.me.apana.org.au>
On Fri, 5 Dec 2003, Herbert Xu wrote:
>
> Linus Torvalds <torvalds@osdl.org> wrote:
> >
> > Really? This actually makes a difference for you? I don't see why it
> > should matter: even if the sector offsets would overflow, why would that
> > cause _oopses_?
>
> Apart from the printk, he also changed dev_info_t which means that any
> place that uses it will be using the 64-bit type now.
I wasn't looking at the printk, I was looking at those 64-bit types. My
argument was that while the small size is incorrect, it shouldn't cause
system stability issues per se - it should just cause IO to potentially
"wrap around" and go to the wrong place on disk.
Which is very serious in itself, of course - but what surprised me was the
quoted system stability things.
Anyway, that patch only matters for the LINEAR MD module, and only for
2TB+ aggregate disks at that, so it doesn't explain any of the other
problematic behaviour. Something else is up.
Linus
next prev parent reply other threads:[~2003-12-04 21:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-01 14:06 Reproducable OOPS with MD RAID-5 on 2.6.0-test11 Kevin P. Fleming
2003-12-01 14:11 ` Jens Axboe
2003-12-01 14:15 ` Kevin P. Fleming
2003-12-01 15:51 ` Jens Axboe
2003-12-02 4:02 ` Kevin P. Fleming
2003-12-02 4:15 ` Mike Fedyk
2003-12-02 13:11 ` Kevin P. Fleming
2003-12-02 8:27 ` Jens Axboe
2003-12-02 10:10 ` Nathan Scott
2003-12-02 13:15 ` Kevin P. Fleming
2003-12-03 3:32 ` Nathan Scott
2003-12-03 17:13 ` Linus Torvalds
2003-12-02 18:23 ` Linus Torvalds
2003-12-04 1:12 ` Simon Kirby
2003-12-04 1:23 ` Linus Torvalds
2003-12-04 4:31 ` Simon Kirby
2003-12-05 6:55 ` Theodore Ts'o
2003-12-04 20:53 ` Herbert Xu
2003-12-04 21:06 ` Linus Torvalds [this message]
2003-12-01 23:06 ` Reproducable OOPS with MD RAID-5 on 2.6.0-test11 - with XFS Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0312041304120.6638@home.osdl.org \
--to=torvalds@osdl.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).