From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261357AbVACBmQ (ORCPT ); Sun, 2 Jan 2005 20:42:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261381AbVACBmQ (ORCPT ); Sun, 2 Jan 2005 20:42:16 -0500 Received: from fw.osdl.org ([65.172.181.6]:44235 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S261357AbVACBmN (ORCPT ); Sun, 2 Jan 2005 20:42:13 -0500 Date: Sun, 2 Jan 2005 17:41:57 -0800 (PST) From: Linus Torvalds To: Andi Kleen cc: linux-kernel@vger.kernel.org, davidel@xmailserver.org, mh@codeweavers.com, the3dfxdude@gmail.com Subject: Re: [PATCH] Fix typo in i386 single step changes In-Reply-To: <20050103000130.GA74276@muc.de> Message-ID: References: <20050102234155.GA29453@nevyn.them.org> <20050103000130.GA74276@muc.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 3 Jan 2005, Andi Kleen wrote: > > Also looking at the code more closely the comment above doesn't > match what the code does. I fixed that too. The comment is slightly stale, but yours perpetuates the staleness, and doesn't fix the first comment which also talks about staleness. Back when we were really broken with TF handling, we also used to set TF when we started single-stepping, but we never cleared it until we got a stale DR_STEP event. In fact, we could have the debugger detach from the process, and leave TF set. That's not true any more, and I don't think it was true even before the latest changes - the code (and comment) has been stale for quite a while. So the whole "lazy TF" thing is really incorrect, and these days it's about the user setting TF on its own. And the _code_ was corrupted too (and working, but only because it could never trigger anyway). I'll remove it and fix up the comments. Linus