From: Linus Torvalds <torvalds@osdl.org>
To: Andrew Morton <akpm@osdl.org>
Cc: David Howells <dhowells@redhat.com>,
keyrings@linux-nfs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Keys: Add possessor permissions to keys
Date: Wed, 21 Sep 2005 11:56:10 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0509211154210.2553@g5.osdl.org> (raw)
In-Reply-To: <20050921114533.76815f03.akpm@osdl.org>
On Wed, 21 Sep 2005, Andrew Morton wrote:
>
> hrmph. Of course it's a reasonable trick from a performance and
> convenience and resource consumption POV. But it's a new idiom and the
> threshold for new idioms is non-zero. We use it in struct page, but struct
> page is special.
Hmm.. I don't feel it is that new, but maybe that's because I've used that
trick in other places. I think it's pretty common in a "type-safe C" way,
and it should probably be encouraged. A unique pointer type for special
usages, that you can't dereference even by mistake..
But adding a few comments might certainly be worth it. If only to teach
others the trick.
Linus
next prev parent reply other threads:[~2005-09-21 18:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5378.1127211442@warthog.cambridge.redhat.com>
2005-09-21 14:48 ` [PATCH] Keys: Add possessor permissions to keys David Howells
2005-09-21 15:05 ` Linus Torvalds
2005-09-21 15:44 ` David Howells
2005-09-21 17:15 ` Andrew Morton
2005-09-21 17:47 ` Trond Myklebust
2005-09-21 18:36 ` David Howells
2005-09-21 18:29 ` David Howells
2005-09-21 18:45 ` Andrew Morton
2005-09-21 18:56 ` Linus Torvalds [this message]
2005-09-22 10:00 ` David Howells
2005-10-03 4:43 ` [Keyrings] " Kyle Moffett
2005-09-21 19:23 ` James Morris
2005-09-21 18:33 ` [PATCH] Keys: Add possessor permissions to keys [try #2] David Howells
2005-09-28 16:03 ` [PATCH] Keys: Add possessor permissions to keys [try #3] David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0509211154210.2553@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=keyrings@linux-nfs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).