From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>,
Stefan Rompf <stefan@loplof.de>,
Arjan van de Ven <arjan@infradead.org>,
Andrew Morton <akpm@osdl.org>,
Clemens Fruhwirth <clemens@endorphin.org>,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [Patch 2.6] dm-crypt: zero key before freeing it
Date: Wed, 4 Jan 2006 12:43:21 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.58.0601041242270.19134@shark.he.net> (raw)
In-Reply-To: <20060104204129.GA12339@wohnheim.fh-wedel.de>
On Wed, 4 Jan 2006, Jörn Engel wrote:
> On Wed, 4 January 2006 12:28:59 -0800, Randy.Dunlap wrote:
> > On Wed, 4 Jan 2006, Stefan Rompf wrote:
> > > Am Mittwoch 04 Januar 2006 21:09 schrieb Arjan van de Ven:
> > >
> > > > since a memset right before a free is a very unusual code pattern in the
> > > > kernel it may well be worth putting a short comment around it to prevent
> > > > someone later removing it as "optimization"
> > >
> > > Valid objection, here is an update (and see, I'm running 2.6.15 now ;-)
> >
> > A reason "why" would be more helpful that a "what".
>
> "prevent information leak"
>
> This is still a "what", but at least not a "how".
OK, that's a much better changelog entry or source code comment...
if it could be put in one of those places.
Thanks.
--
~Randy
next prev parent reply other threads:[~2006-01-04 20:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-04 20:08 [Patch 2.6] dm-crypt: zero key before freeing it Stefan Rompf
2006-01-04 20:09 ` Arjan van de Ven
2006-01-04 20:26 ` Stefan Rompf
2006-01-04 20:28 ` Randy.Dunlap
2006-01-04 20:41 ` Jörn Engel
2006-01-04 20:43 ` Randy.Dunlap [this message]
2006-01-04 21:15 ` [stable] " Greg KH
2006-01-04 21:44 ` [Patch 2.6] dm-crypt: Zero key material before free to avoid information leak Stefan Rompf
2006-01-24 4:49 ` [Patch 2.6] dm-crypt: zero key before freeing it Neil Brown
2006-01-24 21:29 ` Stefan Rompf
2006-01-24 21:44 ` Neil Brown
2006-01-24 23:03 ` Phillip Susi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0601041242270.19134@shark.he.net \
--to=rdunlap@xenotime.net \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=clemens@endorphin.org \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=stefan@loplof.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).