From: Anton Altaparmakov <aia21@cam.ac.uk>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
linux-ntfs-dev@lists.sourceforge.net
Subject: [PATCH 24/37] Re: [2.6-BK-URL] NTFS: 2.1.21 - Big update with race/bug fixes
Date: Tue, 19 Oct 2004 10:44:40 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.60.0410191044280.24986@hermes-1.csi.cam.ac.uk> (raw)
In-Reply-To: <Pine.LNX.4.60.0410191044130.24986@hermes-1.csi.cam.ac.uk>
This is patch 24/37 in the series. It contains the following ChangeSet:
<aia21@cantab.net> (04/10/12 1.2041.1.2)
NTFS: Attempting to write outside initialized size is _not_ a bug so remove
the bug check from fs/ntfs/aops.c::ntfs_write_mst_block(). It is in
fact required to write outside initialized size when preparing to
extend the initialized size.
Signed-off-by: Anton Altaparmakov <aia21@cantab.net>
Best regards,
Anton
--
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/, http://www-stu.christs.cam.ac.uk/~aia21/
===================================================================
diff -Nru a/fs/ntfs/ChangeLog b/fs/ntfs/ChangeLog
--- a/fs/ntfs/ChangeLog 2004-10-19 10:14:33 +01:00
+++ b/fs/ntfs/ChangeLog 2004-10-19 10:14:33 +01:00
@@ -76,6 +76,10 @@
- Modify fs/ntfs/mft.c::write_mft_record_nolock() so that it only
writes the mft record if the buffers belonging to it are dirty.
Otherwise we assume that it was written out by other means already.
+ - Attempting to write outside initialized size is _not_ a bug so remove
+ the bug check from fs/ntfs/aops.c::ntfs_write_mst_block(). It is in
+ fact required to write outside initialized size when preparing to
+ extend the initialized size.
2.1.20 - Fix two stupid bugs introduced in 2.1.18 release.
diff -Nru a/fs/ntfs/aops.c b/fs/ntfs/aops.c
--- a/fs/ntfs/aops.c 2004-10-19 10:14:33 +01:00
+++ b/fs/ntfs/aops.c 2004-10-19 10:14:33 +01:00
@@ -892,8 +892,6 @@
}
BUG_ON(!rec_is_dirty);
}
- /* Attempting to write outside the initialized size is a bug. */
- BUG_ON(((block + 1) << bh_size_bits) > ni->initialized_size);
if (!buffer_mapped(bh)) {
ntfs_error(vol->sb, "Writing ntfs records without "
"existing mapped buffers is not "
next prev parent reply other threads:[~2004-10-19 10:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-19 9:37 [2.6-BK-URL] NTFS: 2.1.21 - Big update with race/bug fixes Anton Altaparmakov
2004-10-19 9:38 ` [PATCH 1/37] " Anton Altaparmakov
2004-10-19 9:39 ` [PATCH 2/37] " Anton Altaparmakov
2004-10-19 9:39 ` [PATCH 3/37] " Anton Altaparmakov
2004-10-19 9:39 ` [PATCH 4/37] " Anton Altaparmakov
2004-10-19 9:40 ` [PATCH 5/37] " Anton Altaparmakov
2004-10-19 9:40 ` [PATCH 6/37] " Anton Altaparmakov
2004-10-19 9:40 ` [PATCH 7/37] " Anton Altaparmakov
2004-10-19 9:40 ` [PATCH 8/37] " Anton Altaparmakov
2004-10-19 9:41 ` [PATCH 9/37] " Anton Altaparmakov
2004-10-19 9:41 ` [PATCH 10/37] " Anton Altaparmakov
2004-10-19 9:41 ` [PATCH 11/37] " Anton Altaparmakov
2004-10-19 9:41 ` [PATCH 12/37] " Anton Altaparmakov
2004-10-19 9:41 ` [PATCH 13/37] " Anton Altaparmakov
2004-10-19 9:42 ` [PATCH 14/37] " Anton Altaparmakov
2004-10-19 9:42 ` [PATCH 15/37] " Anton Altaparmakov
2004-10-19 9:42 ` [PATCH 16/37] " Anton Altaparmakov
2004-10-19 9:42 ` [PATCH 17/37] " Anton Altaparmakov
2004-10-19 9:43 ` [PATCH 18/37] " Anton Altaparmakov
2004-10-19 9:43 ` [PATCH 19/37] " Anton Altaparmakov
2004-10-19 9:43 ` [PATCH 20/37] " Anton Altaparmakov
2004-10-19 9:43 ` [PATCH 21/37] " Anton Altaparmakov
2004-10-19 9:44 ` [PATCH 22/37] " Anton Altaparmakov
2004-10-19 9:44 ` [PATCH 23/37] " Anton Altaparmakov
2004-10-19 9:44 ` Anton Altaparmakov [this message]
2004-10-19 9:44 ` [PATCH 25/37] " Anton Altaparmakov
2004-10-19 9:45 ` [PATCH 26/37] " Anton Altaparmakov
2004-10-19 9:45 ` [PATCH 27/37] " Anton Altaparmakov
2004-10-19 9:45 ` [PATCH 28/37] " Anton Altaparmakov
2004-10-19 9:45 ` [PATCH 29/37] " Anton Altaparmakov
2004-10-19 9:46 ` [PATCH 30/37] " Anton Altaparmakov
2004-10-19 9:46 ` [PATCH 31/37] " Anton Altaparmakov
2004-10-19 9:46 ` [PATCH 32/37] " Anton Altaparmakov
2004-10-19 9:46 ` [PATCH 33/37] " Anton Altaparmakov
2004-10-19 9:47 ` [PATCH 34/37] " Anton Altaparmakov
2004-10-19 9:47 ` [PATCH 35/37] " Anton Altaparmakov
2004-10-19 9:47 ` [PATCH 36/37] " Anton Altaparmakov
2004-10-19 9:48 ` [PATCH 37/37] " Anton Altaparmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.60.0410191044280.24986@hermes-1.csi.cam.ac.uk \
--to=aia21@cam.ac.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).