linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: Andrea Arcangeli <andrea@suse.de>
Cc: linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: VM fixes [4/4]
Date: Mon, 27 Dec 2004 08:38:41 -0500 (EST)	[thread overview]
Message-ID: <Pine.LNX.4.61.0412270837001.19240@chimarrao.boston.redhat.com> (raw)
In-Reply-To: <20041224174156.GE13747@dualathlon.random>

On Fri, 24 Dec 2004, Andrea Arcangeli wrote:

> --- x/mm/oom_kill.c.orig	2004-12-24 17:53:50.807536152 +0100
> +++ x/mm/oom_kill.c	2004-12-24 18:01:19.903263224 +0100
> @@ -45,18 +45,30 @@
> unsigned long badness(struct task_struct *p, unsigned long uptime)
> {

> 	/*
> +	 * Processes which fork a lot of child processes are likely
> +	 * a good choice. We add the vmsize of the childs if they
> +	 * have an own mm. This prevents forking servers to flood the
> +	 * machine with an endless amount of childs
> +	 */

I'm not sure about this one.  You'll end up killing the
parent httpd and sshd, instead of letting them hang around
so the system can recover by itself after the memory use
spike is over.

I guess it all depends on whether your OOM situation is a
spike or a deliberately caused problem...

-- 
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan

  parent reply	other threads:[~2004-12-27 13:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-24 17:41 VM fixes [4/4] Andrea Arcangeli
2004-12-24 18:01 ` David S. Miller
2004-12-24 18:22   ` Andrea Arcangeli
2004-12-24 20:55     ` David S. Miller
2004-12-24 21:25       ` William Lee Irwin III
2004-12-24 23:52         ` William Lee Irwin III
2004-12-24 23:55         ` David S. Miller
2004-12-24 23:41     ` Linus Torvalds
2004-12-25  2:27       ` Andrea Arcangeli
2004-12-25  3:24         ` VM fixes [PF_MEMDIE to TIF_MEMDIE] [5/4] Andrea Arcangeli
2004-12-25 14:53           ` VM fixes [->used_math to PF_USED_MATH] [6/4] Andrea Arcangeli
2004-12-27  7:03             ` Andy Isaacson
2005-01-02 15:41               ` Andrea Arcangeli
2005-01-08 17:17                 ` William Lee Irwin III
2004-12-25  0:06     ` VM fixes [4/4] Mitchell Blank Jr
2004-12-25  2:37       ` Andrea Arcangeli
2004-12-24 23:32 ` Linus Torvalds
2004-12-27 13:38 ` Rik van Riel [this message]
2004-12-28  9:42   ` Thomas Gleixner
2005-01-02 15:51     ` Andrea Arcangeli
2005-01-02 16:44       ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61.0412270837001.19240@chimarrao.boston.redhat.com \
    --to=riel@redhat.com \
    --cc=akpm@osdl.org \
    --cc=andrea@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).