From: Zwane Mwaikambo <zwane@arm.linux.org.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: Chris Wright <chrisw@osdl.org>,
clameter@sgi.com, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fixes for prep_zero_page
Date: Sun, 9 Jan 2005 14:32:00 -0700 (MST) [thread overview]
Message-ID: <Pine.LNX.4.61.0501091409490.13639@montezuma.fsmlabs.com> (raw)
In-Reply-To: <20050109125212.330c34c1.akpm@osdl.org>
On Sun, 9 Jan 2005, Andrew Morton wrote:
> This won't work right if someone tries to allocate memory while holding a
> KM_IRQ0 atomic kmap.
>
> It would be quite bizarre for anyone to be allocating highmem pages from
> IRQ context anyway, but as a generic mechanism this really should work as
> expected in all contexts. That means a new kmap slot.
I was trying to find users of nested KM_IRQ to verify against so i just
went with the first slot. The problem with sharing a slot with irq context
is that you have to exclude interrupts whilst doing the zeroing too,
unless we maybe create two slots.
> Can't we simply move the page zeroing to the very end of __alloc_pages()?
Ok, i've changed that bit to something like;
Index: linux-2.6.10-mm2/mm/page_alloc.c
===================================================================
RCS file: /home/cvsroot/linux-2.6.10-mm2/mm/page_alloc.c,v
retrieving revision 1.1.1.1
diff -u -p -B -r1.1.1.1 page_alloc.c
--- linux-2.6.10-mm2/mm/page_alloc.c 9 Jan 2005 04:52:40 -0000 1.1.1.1
+++ linux-2.6.10-mm2/mm/page_alloc.c 9 Jan 2005 21:23:31 -0000
@@ -732,9 +740,6 @@ buffered_rmqueue(struct zone *zone, int
mod_page_state_zone(zone, pgalloc, 1 << order);
prep_new_page(page, order);
- if (gfp_flags & __GFP_ZERO)
- prep_zero_page(page, order);
-
if (order && (gfp_flags & __GFP_COMP))
prep_compound_page(page, order);
}
@@ -935,6 +940,8 @@ nopage:
got_pg:
zone_statistics(zonelist, z);
kernel_map_pages(page, 1 << order, 1);
+ if (gfp_mask & __GFP_ZERO)
+ prep_zero_page(page, order);
return page;
}
next prev parent reply other threads:[~2005-01-09 21:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-08 9:06 panic on bootup due to __GFP_ZERO patch Chris Wright
2005-01-08 20:00 ` Dave Jones
2005-01-09 9:45 ` Andrew Morton
2005-01-09 15:56 ` [PATCH] Fixes for prep_zero_page Zwane Mwaikambo
2005-01-09 20:52 ` Andrew Morton
2005-01-09 21:32 ` Zwane Mwaikambo [this message]
2005-01-09 22:48 ` Chris Wright
2005-01-10 4:18 ` Zwane Mwaikambo
2005-01-13 5:05 ` Zwane Mwaikambo
2005-01-13 18:24 ` Chris Wright
2005-01-14 0:50 ` Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0501091409490.13639@montezuma.fsmlabs.com \
--to=zwane@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=chrisw@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).