linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jesper Juhl <juhl-lkml@dif.dk>
To: Adrian Bunk <bunk@stusta.de>
Cc: Jesper Juhl <juhl-lkml@dif.dk>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-net <linux-net@vger.kernel.org>,
	netdev <netdev@oss.sgi.com>
Subject: Re: [PATCH] remove unused variables in net/sunrpc/auth.c
Date: Tue, 11 Jan 2005 17:18:22 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.61.0501111716580.3368@dragon.hygekrogen.localhost> (raw)
In-Reply-To: <20050110221651.GA29578@stusta.de>

On Mon, 10 Jan 2005, Adrian Bunk wrote:

> On Mon, Jan 10, 2005 at 10:50:34PM +0100, Jesper Juhl wrote:
> > 
> > We have a few unused variables in net/sunrpc/auth.c:320:
> > 
> > net/sunrpc/auth.c:320: warning: unused variable `auth'
> > net/sunrpc/auth.c:333: warning: unused variable `auth'
> > net/sunrpc/auth.c:345: warning: unused variable `auth'
> > net/sunrpc/auth.c:385: warning: unused variable `auth'
> > 
> > As far as I can see, the patch that caused them to become unused is this 
> > one (which btw is ~36 months old) :
> > http://linux.bkbits.net:8080/linux-2.6/diffs/net/sunrpc/auth.c@1.4?nav=index.html|src/|src/net|src/net/sunrpc|hist/net/sunrpc/auth.c
> > 
> > Here is a patch to get rid of them (compile tested only).
> >...
> 
> Doesn't this break with CONFIG_SYSCTL=y?
> 
Yes, yes it does. I didn't see the CONFIG_SYSCTL connection and thus 
didn't test that :(   
Please disregard the patch, it's wrong.

-- 
Jesper Juhl



      reply	other threads:[~2005-01-11 16:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-10 21:50 [PATCH] remove unused variables in net/sunrpc/auth.c Jesper Juhl
2005-01-10 22:16 ` Adrian Bunk
2005-01-11 16:18   ` Jesper Juhl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61.0501111716580.3368@dragon.hygekrogen.localhost \
    --to=juhl-lkml@dif.dk \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).