From: Roman Zippel <zippel@linux-m68k.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] fs/hfsplus/: move the hfsplus_inode_check() prototype to hfsplus_fs.h
Date: Wed, 14 Dec 2005 23:24:19 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.61.0512142319170.1609@scrub.home> (raw)
In-Reply-To: <20051213170137.GL23349@stusta.de>
Hi,
On Tue, 13 Dec 2005, Adrian Bunk wrote:
> --- linux-2.6.15-rc2-mm1-full/fs/hfsplus/inode.c.old 2005-11-23 16:37:34.000000000 +0100
> +++ linux-2.6.15-rc2-mm1-full/fs/hfsplus/inode.c 2005-11-23 16:37:48.000000000 +0100
> @@ -183,7 +183,6 @@
> hlist_add_head(&inode->i_hash, &HFSPLUS_SB(sb).rsrc_inodes);
> mark_inode_dirty(inode);
> {
> - void hfsplus_inode_check(struct super_block *sb);
> atomic_inc(&HFSPLUS_SB(sb).inode_cnt);
> hfsplus_inode_check(sb);
> }
> @@ -322,7 +321,6 @@
> return NULL;
>
> {
> - void hfsplus_inode_check(struct super_block *sb);
> atomic_inc(&HFSPLUS_SB(sb).inode_cnt);
> hfsplus_inode_check(sb);
> }
As this is only a debug function I don't see much point in cleaning it up.
I'd rather remove it completely (including all references to
last_inode_cnt and inode_cnt).
bye, Roman
next prev parent reply other threads:[~2005-12-14 22:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-13 17:01 [2.6 patch] fs/hfsplus/: move the hfsplus_inode_check() prototype to hfsplus_fs.h Adrian Bunk
2005-12-14 22:24 ` Roman Zippel [this message]
2005-12-15 0:14 ` [2.6 patch] fs/hfsplus/: remove the hfsplus_inode_check() debug function Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2005-11-23 22:35 [2.6 patch] fs/hfsplus/: move the hfsplus_inode_check() prototype to hfsplus_fs.h Adrian Bunk
2005-11-23 22:50 ` Randy.Dunlap
2005-11-23 22:58 ` Adrian Bunk
2005-11-23 23:01 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0512142319170.1609@scrub.home \
--to=zippel@linux-m68k.org \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).