linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Greg KH <gregkh@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-usb-devel@lists.sourceforge.net,
	Grant Coady <gcoady@gmail.com>
Subject: Re: [GIT PATCH] USB patches for 2.6.15-rc3
Date: Wed, 30 Nov 2005 10:23:34 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0511301018280.3099@g5.osdl.org> (raw)
In-Reply-To: <20051130055607.GA4406@kroah.com>



On Tue, 29 Nov 2005, Greg KH wrote:
>
>  include/linux/pci_ids.h           |    3 --
> 
> Grant Coady:
>       pci_ids.h: remove duplicate entries

Why is this in the USB tree, and WHY THE HELL DOES IT EXIST IN THE FIRST 
PLACE?

Not only does it have absolutely nothing to do with USB, it's totally 
bogus and incorrect. The commit log is also non-sensical, since it points 
to a commit that doesn't even exist in that tree.

It causes

	drivers/ide/pci/amd74xx.c:77: error: PCI_DEVICE_ID_AMD_CS5536_IDE undeclared here (not in a function)

Grr.

That hwmon thing didn't seem to have anything to do with usb either.

		Linus

  parent reply	other threads:[~2005-11-30 18:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-30  5:56 [GIT PATCH] USB patches for 2.6.15-rc3 Greg KH
2005-11-30  5:58 ` [PATCH] USB: documentation update Greg KH
2005-11-30  5:58   ` [PATCH] hwmon: w83792d fix unused fan pins Greg KH
2005-11-30  5:58     ` [PATCH] pci_ids.h: remove duplicate entries Greg KH
2005-11-30  5:58       ` [PATCH] Additional device ID for Conexant AccessRunner USB driver Greg KH
2005-11-30  5:58         ` [PATCH] USB: ehci fixups Greg KH
2005-11-30  5:58           ` [PATCH] USB: Fix USB suspend/resume crasher (#2) Greg KH
2005-11-30  8:09         ` [linux-usb-devel] [PATCH] Additional device ID for Conexant AccessRunner USB driver Duncan Sands
2005-11-30 22:30           ` Greg KH
2005-12-01  7:50             ` Duncan Sands
2005-11-30 18:23 ` Linus Torvalds [this message]
2005-11-30 19:35   ` [GIT PATCH] USB patches for 2.6.15-rc3 Greg KH
2005-11-30 20:35     ` Grant Coady
2005-12-01  4:10     ` (no subject) Glenn L Shurson
2005-11-30 19:39 ` [GIT PATCH] USB patches for 2.6.15-rc3 Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0511301018280.3099@g5.osdl.org \
    --to=torvalds@osdl.org \
    --cc=akpm@osdl.org \
    --cc=gcoady@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).