From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751344AbWB1CPg (ORCPT ); Mon, 27 Feb 2006 21:15:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750877AbWB1CPg (ORCPT ); Mon, 27 Feb 2006 21:15:36 -0500 Received: from smtp.osdl.org ([65.172.181.4]:27298 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1750712AbWB1CPf (ORCPT ); Mon, 27 Feb 2006 21:15:35 -0500 Date: Mon, 27 Feb 2006 18:14:41 -0800 (PST) From: Linus Torvalds To: Jeff Garzik cc: Tejun Heo , Mark Lord , David Greaves , Justin Piszcz , linux-kernel@vger.kernel.org, IDE/ATA development list , albertcc@tw.ibm.com, axboe@suse.de Subject: Re: LibPATA code issues / 2.6.15.4 In-Reply-To: <4403B04F.5090405@pobox.com> Message-ID: References: <43F2050B.8020006@dgreaves.com> <200602141300.37118.lkml@rtr.ca> <440040B4.8030808@dgreaves.com> <440083B4.3030307@rtr.ca> <4400A1BF.7020109@rtr.ca> <4400B439.8050202@dgreaves.com> <4401122A.3010908@rtr.ca> <44017B4B.3030900@dgreaves.com> <4401B560.40702@rtr.ca> <4403704E.4090109@rtr.ca> <4403A84C.6010804@gmail.com> <4403B04F.5090405@pobox.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Feb 2006, Jeff Garzik wrote: > > I've had this waiting in the wings, in fact... [see attached] I really hate having a _global_ variable called "fua". That's just bad taste. I would suggest calling it "atapi_forced_unit_attention_enabled", but maybe that is going a bit overboard. It's definitely better than just "fua", though. Linus