From: Linus Torvalds <torvalds@osdl.org>
To: Edgar Hucek <hostmaster@ed-soft.at>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
"H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>,
akpm@osdl.org
Subject: Re: [PATCH 1/1] Fix boot on efi 32 bit Machines [try #4]
Date: Fri, 14 Jul 2006 09:09:55 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0607140901200.5623@g5.osdl.org> (raw)
In-Reply-To: <44B73791.9080601@ed-soft.at>
On Fri, 14 Jul 2006, Edgar Hucek wrote:
>
> This is the memory map from the efi shell :
Ok, it really looks like EFI is broken. You said that "ACPI_MCFG table
returns e0000000", ie we should find the config space thing there, yet:
> [ snip snip ... ]
> ACPI_recl 000000007EEEF000-000000007EEFEFFF 0000000000000010 000000000000000F
> RT_data 000000007EEFF000-000000007EEFFFFF 0000000000000001 800000000000000F
> MemMapIO 00000000E00F8000-00000000E00F8FFF 0000000000000001 8000000000000000
> MemMapIO 00000000FED1C000-00000000FED1FFFF 0000000000000004 8000000000000000
> MemMapIO 00000000FFFB0000-00000000FFFDFFFF 0000000000000030 8000000000000000
It clearly wasn't there..
However, it looks like your conversion is a bit buggy:
> This is the converted memory map :
>
> [ snip snip .. ]
> BIOS-EFI: 000000007eeef000 - 000000007eeff000 (ACPI data)
> BIOS-EFI: 00000000e00f8000 - 00000000e00f9000 (reserved)
> BIOS-EFI: 00000000fed1c000 - 00000000fed20000 (reserved)
> BIOS-EFI: 00000000fffb0000 - 00000000fffe0000 (reserved)
The above is missing the "RT_data" thing (which was there in your input):
mem31: type=6, attr=0x800000000000000f, range=[0x000000007eeff000-0x000000007ef00000) (0MB)
> This is the funktion i used for converting :
>
> case EFI_RESERVED_TYPE:
> case EFI_MEMORY_MAPPED_IO:
> case EFI_MEMORY_MAPPED_IO_PORT_SPACE:
> case EFI_UNUSABLE_MEMORY:
> add_memory_region(md->phys_addr, md->num_pages << EFI_PAGE_SHIFT, E820_RESERVED);
> break;
I think that should be a "default:", to make sure that you don't have any
memory region types that get ignored. Because it looks like you missed the
EFI_RUNTIME_SERVICES_CODE/EFI_RUNTIME_SERVICES_DATA ones at a minimum (an
dmaybe others - I didn't check).
Anyway, that won't fix your bug, and yes, it sounds like you should add a
PCI_PROBE_FORCE_MMCFG flag (and then do the proper MMIO region reservation
to make sure that we don't allocate over it when allocating PCI
resources).
Looks good otherwise.
Linus
next prev parent reply other threads:[~2006-07-14 16:10 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-26 21:19 [PATCH 1/1] Fix boot on efi 32 bit Machines [try #4] Edgar Hucek
2006-06-26 21:33 ` Linus Torvalds
2006-06-27 6:15 ` Edgar Hucek
2006-06-27 6:20 ` Linus Torvalds
2006-06-28 22:37 ` H. Peter Anvin
2006-07-02 17:39 ` Eric W. Biederman
2006-07-02 17:42 ` H. Peter Anvin
2006-07-02 18:26 ` Eric W. Biederman
2006-07-02 18:46 ` Arjan van de Ven
2006-07-05 9:38 ` Edgar Hucek
2006-07-05 15:52 ` Eric W. Biederman
2006-07-13 21:46 ` Edgar Hucek
2006-07-13 22:15 ` Linus Torvalds
2006-07-14 4:23 ` Eric W. Biederman
2006-07-14 6:22 ` H. Peter Anvin
2006-07-14 6:20 ` Edgar Hucek
2006-07-14 16:09 ` Linus Torvalds [this message]
2006-07-16 8:55 ` [PATCH 1/1] Add efi e820 memory mapping on x86 [try #1] Edgar Hucek
2006-07-25 4:29 ` Andrew Morton
2006-07-25 5:17 ` Eric W. Biederman
2006-07-25 5:32 ` Linus Torvalds
2006-07-25 5:34 ` H. Peter Anvin
2006-07-25 5:44 ` Linus Torvalds
2006-07-25 6:26 ` H. Peter Anvin
2006-07-25 6:00 ` Linus Torvalds
2006-07-16 9:00 ` [PATCH 1/1] Add force of use MMCONFIG " Edgar Hucek
2006-07-25 4:33 ` Andrew Morton
2006-07-25 5:27 ` Linus Torvalds
2006-07-26 15:05 ` Andi Kleen
2006-06-26 22:22 [PATCH 1/1] Fix boot on efi 32 bit Machines [try #4] Thomas Meyer
2006-07-14 13:57 Chuck Ebbert
2006-07-14 14:45 ` Edgar Hucek
2006-07-14 19:28 ` Edgar Hucek
2006-07-16 12:09 Thomas Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0607140901200.5623@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=hostmaster@ed-soft.at \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).