From: Linus Torvalds <torvalds@osdl.org>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: Ashok Raj <ashok.raj@intel.com>,
linux-kernel@vger.kernel.org, davej@redhat.com,
Andrew Morton <akpm@osdl.org>
Subject: Re: remove cpu hotplug bustification in cpufreq.
Date: Sun, 23 Jul 2006 11:12:24 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0607231107510.29649@g5.osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0607230955130.29649@g5.osdl.org>
On Sun, 23 Jul 2006, Linus Torvalds wrote:
>
> Does this work? Hey, it works for me once. It's pretty simple, and had
> better not have any recursion issues.
GAAH!!
What kind of _crap_ is this cpufreq thing?
Lookie here:
S06cpuspeed D DD94A324 2180 10241 10215 (NOTLB)
Call Trace:
[<c03c411d>] __mutex_lock_slowpath+0x4d/0x7b
[<c03c415a>] .text.lock.mutex+0xf/0x14
[<c0137651>] lock_cpu_hotplug+0xd/0xf
[<c012f9df>] __create_workqueue+0x52/0x11f
[<df0cd336>] cpufreq_governor_dbs+0x9e/0x2c5 [cpufreq_ondemand]
[<c0305d2a>] __cpufreq_governor+0x57/0xd8
[<c0305ee8>] __cpufreq_set_policy+0x13d/0x1a9
[<c03060e4>] store_scaling_governor+0x12d/0x155
[<c03057a5>] store+0x34/0x45
[<c0199a6c>] sysfs_write_file+0x99/0xbf
[<c0164ac3>] vfs_write+0xab/0x157
[<c01650fc>] sys_write+0x3b/0x60
[<c0102d41>] sysenter_past_esp+0x56/0x79
where it takes the cpu_hotplug lock in "store_scaling_governor()", and
then calls __cpufreq_set_policy(), and then that ondemand thing WILL TAKE
IT AGAIN!
What a piece of crap. Why, why, why?
[ Linus bangs his head against the wall until tears of blood course down
his face ]
I will here-by re-introduce the recursion thing for lock_cpu_hotplug, but
I will make it say some very rude things about idiots who create code like
this.
cpufreq (or at least ondemand) must DIE! And the people who wrote that
crap should have red-hot pokers jammed into some very uncomfortable
places.
Linus
next prev parent reply other threads:[~2006-07-23 18:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-22 19:40 remove cpu hotplug bustification in cpufreq Dave Jones
2006-07-23 0:10 ` Linus Torvalds
2006-07-23 1:06 ` Andrew Morton
2006-07-23 1:15 ` Linus Torvalds
2006-07-23 4:09 ` Arjan van de Ven
2006-07-23 17:20 ` Linus Torvalds
2006-07-23 18:12 ` Linus Torvalds [this message]
2006-07-23 18:34 ` Patrick McFarland
2006-07-24 10:52 ` Arjan van de Ven
2006-07-23 5:34 ` Andrew Morton
2006-07-23 8:29 ` Arjan van de Ven
2006-07-23 16:24 ` Ingo Molnar
2006-07-25 0:21 Chuck Ebbert
2006-07-25 0:59 ` Linus Torvalds
2006-07-25 15:06 ` Erik Mouw
2006-07-25 18:54 ` Ingo Molnar
2006-07-25 19:30 ` Arjan van de Ven
2006-07-25 20:57 ` Linus Torvalds
2006-07-25 20:46 ` Dave Jones
2006-07-25 20:59 ` Linus Torvalds
2006-07-26 17:12 ` Russell King
2006-07-26 17:53 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0607231107510.29649@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=akpm@osdl.org \
--cc=arjan@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).