From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932479AbWGYVHQ (ORCPT ); Tue, 25 Jul 2006 17:07:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932492AbWGYVHP (ORCPT ); Tue, 25 Jul 2006 17:07:15 -0400 Received: from smtp.osdl.org ([65.172.181.4]:30659 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932479AbWGYVHO (ORCPT ); Tue, 25 Jul 2006 17:07:14 -0400 Date: Tue, 25 Jul 2006 13:57:16 -0700 (PDT) From: Linus Torvalds To: Arjan van de Ven cc: Ingo Molnar , Chuck Ebbert <76306.1226@compuserve.com>, Ashok Raj , linux-kernel , Dave Jones , Andrew Morton Subject: Re: remove cpu hotplug bustification in cpufreq. In-Reply-To: <1153855844.8932.56.camel@laptopd505.fenrus.org> Message-ID: References: <200607242023_MC3-1-C5FE-CADB@compuserve.com> <20060725185449.GA8074@elte.hu> <1153855844.8932.56.camel@laptopd505.fenrus.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Jul 2006, Arjan van de Ven wrote: > > so cpufreq_set_policy() takes policy->lock, and then calls into the > userspace governer code > (__cpufreq_set_policy->cpufreq_governor->cpufreq_governor_userspace) > which calls __cpufreq_driver_target... which does lock_cpu_hotplug(). Yeah. I think the target should _not_ take the lock_cpu_hotplug(), since the call chain (much much earlier) should have done it. Ie we should probably do it at the "cpufreq_set_policy()" level. > Arjan -- who's just cleaned Linus' wall to prepare it for more head > banging It's not actually "my wall". I'll happily share it with anybody else. Please. Take my wall. Linus