From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161398AbWLPTSA (ORCPT ); Sat, 16 Dec 2006 14:18:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161399AbWLPTSA (ORCPT ); Sat, 16 Dec 2006 14:18:00 -0500 Received: from excu-mxob-1.symantec.com ([198.6.49.12]:56398 "EHLO excu-mxob-1.symantec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161398AbWLPTR6 (ORCPT ); Sat, 16 Dec 2006 14:17:58 -0500 X-AuditID: c606310c-a3eecbb0000072e7-9a-458448b6f6a3 Date: Sat, 16 Dec 2006 19:18:19 +0000 (GMT) From: Hugh Dickins X-X-Sender: hugh@blonde.wat.veritas.com To: Martin Michlmayr cc: Marc Haber , Jan Kara , Peter Zijlstra , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: 2.6.19 file content corruption on ext3 In-Reply-To: <20061216184310.GA891@unjust.cyrius.com> Message-ID: References: <20061207155740.GC1434@torres.l21.ma.zugschlus.de> <4578465D.7030104@cfl.rr.com> <20061209092639.GA15443@torres.l21.ma.zugschlus.de> <20061216184310.GA891@unjust.cyrius.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-OriginalArrivalTime: 16 Dec 2006 19:17:57.0751 (UTC) FILETIME=[E50B7870:01C72146] X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 16 Dec 2006, Martin Michlmayr wrote: > * Marc Haber [2006-12-09 10:26]: > > Unfortunately, I am lacking the knowledge needed to do this in an > > informed way. I am neither familiar enough with git nor do I possess > > the necessary C powers. > > I wonder if what you're seein is related to > http://lkml.org/lkml/2006/12/16/73 > > You said that you don't see any corruption with 2.6.18. Can you try > to apply the patch from > http://www2.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=d08b3851da41d0ee60851f2c75b118e1f7a5fc89 > to 2.6.18 to see if the corruption shows up? I did wonder about the very first hunk of Peter's patch, where the mapping->private_lock is unlocked earlier now in try_to_free_buffers, before the clear_page_dirty. I'm not at all familiar with that area, I wonder if Jan has looked at that change, and might be able to say whether it's good or not (earlier he worried about his JBD changes, but they wouldn't be implicated if just 2.6.18+Peter's gives trouble). Hugh