From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754942AbWL1T3U (ORCPT ); Thu, 28 Dec 2006 14:29:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754943AbWL1T3U (ORCPT ); Thu, 28 Dec 2006 14:29:20 -0500 Received: from smtp.osdl.org ([65.172.181.25]:53463 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754941AbWL1T3U (ORCPT ); Thu, 28 Dec 2006 14:29:20 -0500 Date: Thu, 28 Dec 2006 11:28:52 -0800 (PST) From: Linus Torvalds To: Guillaume Chazarain cc: David Miller , ranma@tdiedrich.de, gordonfarquharson@gmail.com, tbm@cyrius.com, Peter Zijlstra , andrei.popa@i-neo.ro, Andrew Morton , hugh@veritas.com, nickpiggin@yahoo.com.au, arjan@infradead.org, Linux Kernel Mailing List , Chen Kenneth W Subject: Re: [PATCH] mm: fix page_mkclean_one In-Reply-To: <459418D2.2000702@yahoo.fr> Message-ID: References: <20061226.205518.63739038.davem@davemloft.net> <20061227.165246.112622837.davem@davemloft.net> <4593DE31.4070401@yahoo.fr> <459418D2.2000702@yahoo.fr> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 Dec 2006, Guillaume Chazarain wrote: > > The attached patch fixes the corruption for me. Well, that's a good hint, but it's really just a symptom. You effectively just made the test-program not even try to flush the data to disk, so the page cache would stay in memory, and you'd not see the corruption as well. So you basically disabled the code that tried to trigger the bug more easily. But the reason I say it's interesting is that "WB_SYNC_NONE" is very much implicated in mm/page-writeback.c, and if there is a bug triggered by WB_SYNC_NONE writebacks, then that would explain why page-writeback.c also fails.. Linus