From: Jiri Kosina <jkosina@suse.cz>
To: "Ahmed S. Darwish" <darwish.07@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.20-rc3] HID-Core: Tiny patch to remove a kmalloc cast
Date: Sat, 6 Jan 2007 17:18:09 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0701061715300.3771@jikos.suse.cz> (raw)
In-Reply-To: <20070106131852.GF19020@Ahmed>
On Sat, 6 Jan 2007, Ahmed S. Darwish wrote:
> Signed-off-by: Ahmed Darwish <darwish.07@gmail.com>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 18c2b3c..2fcfdbb 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -656,7 +656,7 @@ struct hid_device *hid_parse_report(__u8 *start, unsigned size)
> for (i = 0; i < HID_REPORT_TYPES; i++)
> INIT_LIST_HEAD(&device->report_enum[i].report_list);
>
> - if (!(device->rdesc = (__u8 *)kmalloc(size, GFP_KERNEL))) {
> + if (!(device->rdesc = kmalloc(size, GFP_KERNEL))) {
> kfree(device->collection);
> kfree(device);
> return NULL;
Queued for upstream, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2007-01-06 16:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-06 13:18 [PATCH 2.6.20-rc3] HID-Core: Tiny patch to remove a kmalloc cast Ahmed S. Darwish
2007-01-06 16:18 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0701061715300.3771@jikos.suse.cz \
--to=jkosina@suse.cz \
--cc=darwish.07@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).