From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933623AbXCMVUz (ORCPT ); Tue, 13 Mar 2007 17:20:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933372AbXCMVUz (ORCPT ); Tue, 13 Mar 2007 17:20:55 -0400 Received: from smtp.osdl.org ([65.172.181.24]:35735 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933623AbXCMVUy (ORCPT ); Tue, 13 Mar 2007 17:20:54 -0400 Date: Tue, 13 Mar 2007 14:20:03 -0700 (PDT) From: Linus Torvalds To: Cornelia Huck cc: Alan Stern , Hugh Dickins , Dmitry Torokhov , Oliver Neukum , Maneesh Soni , gregkh@suse.de, Richard Purdie , James Bottomley , Kernel development list Subject: Re: 2.6.21-rc suspend regression: sysfs deadlock In-Reply-To: <20070313194204.5192ab19@gondolin.boeblingen.de.ibm.com> Message-ID: References: <1173735075.5936.139.camel@localhost.localdomain> <20070313194204.5192ab19@gondolin.boeblingen.de.ibm.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Mar 2007, Cornelia Huck wrote: > > Another call that deadlocked with Oliver's patch is ungroup for s390 > ccwgroup devices. It can be made to work again with a similar patch. Could we please make this easier to use by having some common sysfs helper routine for this kind of "delayed_store()" functionality. I'm not a huge fan of delayed work at all, but if we have to have it, at least make it one generic function rather than having multiple functions all doing their own workqueue logic for it. Linus