From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932437AbXCMTBB (ORCPT ); Tue, 13 Mar 2007 15:01:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932583AbXCMTBA (ORCPT ); Tue, 13 Mar 2007 15:01:00 -0400 Received: from extu-mxob-2.symantec.com ([216.10.194.135]:19093 "EHLO extu-mxob-2.symantec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932437AbXCMTBA (ORCPT ); Tue, 13 Mar 2007 15:01:00 -0400 X-AuditID: d80ac287-9edd6bb000000de9-ea-45f6f4eb1d6a Date: Tue, 13 Mar 2007 19:00:59 +0000 (GMT) From: Hugh Dickins X-X-Sender: hugh@blonde.wat.veritas.com To: Alan Stern cc: Dmitry Torokhov , Oliver Neukum , Maneesh Soni , gregkh@suse.de, Richard Purdie , James Bottomley , Linus Torvalds , Kernel development list Subject: Re: 2.6.21-rc suspend regression: sysfs deadlock In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-OriginalArrivalTime: 13 Mar 2007 19:00:59.0029 (UTC) FILETIME=[EFC71450:01C765A1] X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Mar 2007, Alan Stern wrote: > > The consensus is that we would be better off keeping Oliver's original > patch without your silly change, and instead fixing the particular method > call that deadlocked. Can you please try out the patch below with > everything else as it was before? It should solve your problem. Yep, it works fine with your patch in and my silly reverted, thanks. But (I was about to say, even before seeing Cornelia's reply, honest!) I think you do need to check (audit the source? or is some runtime check possible?) for other such "suicidal" sysfs files, which seemed to (sysfs-ignorant) me to pose the real problem. Hugh