From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757256AbXFOTbz (ORCPT ); Fri, 15 Jun 2007 15:31:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756593AbXFOTb3 (ORCPT ); Fri, 15 Jun 2007 15:31:29 -0400 Received: from sovereign.computergmbh.de ([85.214.69.204]:24484 "EHLO sovereign.computergmbh.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756538AbXFOTb2 (ORCPT ); Fri, 15 Jun 2007 15:31:28 -0400 Date: Fri, 15 Jun 2007 21:31:27 +0200 (CEST) From: Jan Engelhardt To: "Kok, Auke" cc: Cyrill Gorcunov , Randy Dunlap , Chris Friesen , dave young , Willy Tarreau , LKML Subject: Re: coding style In-Reply-To: <4672E6B3.1080205@intel.com> Message-ID: References: <20070614184836.GA6520@cvg> <20070615045111.GU943@1wt.eu> <46721F18.8090303@intel.com> <20070615173206.GA8151@cvg> <4672D246.2040306@nortel.com> <20070615110326.b0762b7a.randy.dunlap@oracle.com> <20070615191804.GC8151@cvg> <4672E6B3.1080205@intel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Jun 15 2007 12:21, Kok, Auke wrote: > Cyrill Gorcunov wrote: >> [Jan Engelhardt - Fri, Jun 15, 2007 at 09:10:49PM +0200] >> | On Jun 15 2007 11:03, Randy Dunlap wrote: >> | > > >> | > > "use tabs for indents and spaces for alignment" >> | > > >> | > > If that means you need to use two dozen spaces, then so be it. >> | > >> | >I don't think that's what that rule means, but I didn't write it, >> | >so I'm not absolutely sure about it. >> | > >> | >but we know that tab stops are every 8th character, not 4 :) >> | >> | Hardly. >> | >> Jan, as I see from CodingStyle: >> >> "Tabs are 8 characters, and thus indentations are also 8 characters." >> >> Actually it would be perfect to get strict rules also for math. and log. >> operators being splitted on several lines: > > this doesn't say anything about alignment, which was his point :) Well tabs should _never_ be assumed to be 8, and in this regard, as I see it, CodingStyle has a bug. Tabs are there so that the user can set their width according to _their_ taste, simply so that both sides, from CodingStyle: Tabs are 8 characters, and thus indentations are also 8 characters. There are heretic movements that try to make indentations 4 (or even 2!) characters deep, and that is akin to trying to define the value of PI to be 3. Linus (did he wrote that part?) and the heretics both can have their fun without impacting each other. If we wanted to force the user to have exactly 8 screen blanks, we should use spaces throughout. (And BTW, int pi = 3.141592 _is_ going to be 3 ;-) and floating point is mostly an agreed no-go in kernel anyway, even if it's supported.) Jan --