From: Roman Zippel <zippel@linux-m68k.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
akpm@linux-foundation.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] msleep() with hrtimers
Date: Tue, 7 Aug 2007 14:45:12 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0708071417200.1817@scrub.home> (raw)
In-Reply-To: <1186415621.2706.4.camel@laptopd505.fenrus.org>
Hi,
On Mon, 6 Aug 2007, Arjan van de Ven wrote:
> So, let me ask a direct question: What do you think is specifically
> wrong about changing the msleep() implementation as is done here? The
> behavior is clearly an improvement, so what is your objection on the
> flipside?
Again, we have two different timer APIs for a reason - as long as you
ignore this, we won't get much further...
As long as resolution is not an issue, simple timer are generally often
the better choice as they are cheaper. By extension it also makes sense to
offer a sleep based on simple timer.
hrtimer allows for finer resolution, so it makes more sense to offer a
hrtimer based sleep which is not limited to milliseconds, once we have
this sleep, you'll also get the better behaviour you're asking for, which
removes the urgent need having to "fix" msleep.
Contrary to what you think I don't hate hrtimer, they're quite useful, but
they have their use cases as simple timer have. What I want is that people
_think_ before start using them, as in general hrtimer come with a higher
base cost, so one should _think_ before thoughtlessly using them only
because they're the cool new thing. I don't care much about drivers, but
in generic code (which msleep is part of) I'm going to look closer and
I'll continue to ask, whether it really needs to use hrtimer.
In this case I simply see no reason to force hrtimer on msleep, if users
can as well use nanosleep to get the same behaviour.
bye, Roman
next prev parent reply other threads:[~2007-08-07 12:45 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-03 18:37 [PATCH] msleep() with hrtimers Jonathan Corbet
2007-08-03 18:54 ` Ingo Molnar
2007-08-03 19:19 ` Roman Zippel
2007-08-03 19:46 ` Arjan van de Ven
2007-08-03 19:58 ` Roman Zippel
2007-08-03 23:53 ` Arjan van de Ven
2007-08-04 3:00 ` Roman Zippel
2007-08-04 19:19 ` Arjan van de Ven
2007-08-06 0:09 ` Roman Zippel
2007-08-06 0:43 ` Arjan van de Ven
2007-08-06 1:03 ` Roman Zippel
2007-08-06 5:39 ` Arjan van de Ven
2007-08-06 10:03 ` Roman Zippel
2007-08-06 10:20 ` Manu Abraham
2007-08-06 15:53 ` Arjan van de Ven
2007-08-07 10:40 ` Manu Abraham
2007-08-07 12:45 ` Roman Zippel [this message]
2007-08-08 4:15 ` Arjan van de Ven
2007-08-09 19:31 ` Denis Vlasenko
2007-08-09 20:01 ` Denis Vlasenko
2007-08-07 19:40 ` Andrew Morton
2007-08-07 23:16 ` Roman Zippel
2007-08-07 23:29 ` Andrew Morton
2007-08-08 3:47 ` Roman Zippel
2007-08-08 4:14 ` Andrew Morton
2007-08-09 22:31 ` Roman Zippel
2007-08-08 11:55 ` Andi Kleen
2007-08-08 11:09 ` Manu Abraham
2007-08-08 11:52 ` Andi Kleen
2007-08-08 11:59 ` Manu Abraham
2007-08-09 7:16 ` Andrew Morton
2007-08-09 15:08 ` [linux-usb-devel] " Alan Stern
2007-11-28 10:29 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0708071417200.1817@scrub.home \
--to=zippel@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).