linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	Andi Kleen <ak@suse.de>
Subject: Re: [patch 05/14] percpu: Use a Kconfig variable to configure arch specific percpu setup
Date: Wed, 28 Nov 2007 18:06:06 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0711281800100.20125@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <474E1900.1010209@goop.org>

On Wed, 28 Nov 2007, Jeremy Fitzhardinge wrote:

> > percpu references are quite frequent already (vm statistics) and will be 
> > more frequent after we have converted the per cpu arrays to per cpu 
> > allocations.
> >   
> 
> Well, I think the point is moot, because x86 will always use 32-bit
> offsets.  Each reference will only be 1 byte bigger than a normal
> variable reference.

Just because i386 is not able to use it does not mean that other arches 
are not. F.e. IA64 can embedd offsets in the actual instruction (but of 
course not 64bit).

x86_64 can use a 32 bit offset instead of a 64 bit addres because it uses 
the small model. A load of a 64 bit address would require much more 
expensive instructions. A load of a 64 bit address is currently avoided 
through the use of the pda that contains the full 64 bit address in the
data_offset field. Operations on per cpu data on x86_64 must therefore 
first load data_offset via gs and then add the per cpu address to this
offset. Then the per cpu operation is performed on that address.

In order to avoid this situation through one instruction we need a small 
32 bit offset relative to gs. Otherwise we cannot get away from the PDA 
and the use of data_offset.

 

  parent reply	other threads:[~2007-11-29  2:06 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-27  0:14 [patch 00/14] Per cpu code simplification Christoph Lameter
2007-11-27  0:14 ` [patch 01/14] Modules: Handle symbols that have a zero value Christoph Lameter
2007-11-27  0:14 ` [patch 02/14] Modules: Include sections.h to avoid defining linker variables explicitly Christoph Lameter
2007-11-27  0:14 ` [patch 03/14] Modules: Fold percpu_modcopy into module.c and get rid of the macro from hell Christoph Lameter
2007-11-27  0:14 ` [patch 04/14] ia64: Remove the __SMALL_ADDR_AREA attribute for per cpu access Christoph Lameter
2007-11-27  5:20   ` David Mosberger-Tang
2007-11-27 18:15     ` Christoph Lameter
2007-11-27 21:10       ` David Mosberger-Tang
2007-11-27 21:18         ` Christoph Lameter
2007-11-27 21:27           ` David Mosberger-Tang
2007-11-27 22:02             ` Christoph Lameter
2007-11-27  9:30   ` Andreas Schwab
2007-11-27 18:17     ` Christoph Lameter
2007-11-27 21:24       ` Andreas Schwab
2007-11-27 21:38         ` Christoph Lameter
2007-11-27 22:14           ` Adrian Bunk
2007-11-27  0:14 ` [patch 05/14] percpu: Use a Kconfig variable to configure arch specific percpu setup Christoph Lameter
2007-11-27  4:30   ` Rusty Russell
2007-11-27 18:14     ` Christoph Lameter
2007-11-28  1:36       ` Rusty Russell
2007-11-28 18:51         ` Christoph Lameter
2007-11-28 23:17           ` Rusty Russell
2007-11-28 23:36             ` Christoph Lameter
2007-11-30  2:23               ` Rusty Russell
2007-11-28 23:45             ` Jeremy Fitzhardinge
2007-11-29  0:11               ` Christoph Lameter
2007-11-29  1:18                 ` Andi Kleen
2007-11-29  1:27                   ` Christoph Lameter
2007-11-29  1:30                 ` Jeremy Fitzhardinge
2007-11-29  1:32                   ` Andi Kleen
2007-11-29  1:35                   ` Christoph Lameter
2007-11-29  1:42                     ` Jeremy Fitzhardinge
2007-11-29  1:48                       ` Christoph Lameter
2007-11-29  1:54                         ` Jeremy Fitzhardinge
2007-11-29  2:06                       ` Christoph Lameter [this message]
2007-11-29  5:29                         ` Jeremy Fitzhardinge
2007-11-29  6:08                           ` Christoph Lameter
2007-11-29  6:10                           ` Christoph Lameter
2007-11-27 23:40   ` Randy Dunlap
2007-11-28  0:03     ` Christoph Lameter
2007-11-28  0:05       ` Randy Dunlap
2007-11-27  0:14 ` [patch 06/14] percpu: Move arch XX_PER_CPU_XX definitions into linux/percpu.h Christoph Lameter
2007-11-27  0:14 ` [patch 07/14] percpu: Make the asm-generic/percpu.h more generic Christoph Lameter
2007-11-27  0:14 ` [patch 08/14] x86_32: Use generic percpu.h Christoph Lameter
2007-11-27  0:14 ` [patch 09/14] x86_64: Use generic percpu Christoph Lameter
2007-11-27  0:14 ` [patch 10/14] s390: " Christoph Lameter
2007-11-27  0:14 ` [patch 11/14] Powerpc: Use generic per cpu Christoph Lameter
2007-11-27  7:41   ` Kumar Gala
2007-11-27 18:16     ` Christoph Lameter
2007-11-27 20:58       ` Paul Mackerras
2007-11-27 21:13         ` Christoph Lameter
2007-11-28  2:35           ` Paul Mackerras
2007-11-28 18:54             ` Christoph Lameter
2007-12-02 20:55               ` Benjamin Herrenschmidt
2007-11-27  0:14 ` [patch 12/14] Sparc64: Use generic percpu Christoph Lameter
2007-11-27  0:14 ` [patch 13/14] ia64: " Christoph Lameter
2007-11-27  1:37   ` Christoph Lameter
2007-11-27  0:14 ` [patch 14/14] x86: Unify percpu.h Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0711281800100.20125@schroedinger.engr.sgi.com \
    --to=clameter@sgi.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).