From: "Oyvind Aabling" <Oyvind.Aabling@uni-c.dk>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/char/moxa.c, kernel 2.6.23.14
Date: Fri, 25 Jan 2008 00:34:36 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0801250013410.3424@dbs1.uni-c.dtu.dk> (raw)
In-Reply-To: <47975F33.6040206@gmail.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 3925 bytes --]
On Wed, 23 Jan 2008, Jiri Slaby wrote:
> On 01/22/2008 11:23 AM, Oyvind Aabling wrote:
>> On Mon, 21 Jan 2008, Jiri Slaby wrote:
>>> Would you be willing to test such a patch for point no. 3?
>>
>> Yes, I could do that.
>>
>> I can see your point about the non-portability of it, but
>> how about this scenario, to provide backwards compatibility:
>>
>> * We keep the (ugly and non-compatible) MOXA_GET_CONF
>> ioctl, to avoid breaking the old moxaload.
>> Let's rename it to MOXA_GET_CONF_OLD or MOXA_GET_CONF_BAD in the driver.
>> * Create a new MOXA_GET_CONF ioctl (with a new
>> number, of course), that does it "the right way".
>> If you don't like renaming ioctl's, we need a new name for this one.
>> * Rewrite moxaload to either do a kernel version check
>> and use the new ioctl if available or the old if not.
>> Or skip that and let it call the new ioctl first.
>> If it succeeds (system running a newer kernel): fine, and
>> if not (system running an older kernel), use the old ioctl.
>>
>> The MOXA Intellio driver and moxaload have been "broken" ever since they
>> were written in 1999, and this way, we don't break anything - you can
>> use old or new kernel, and old or new moxaload in any combination.
>>
>> Whaddaya think ?
>
> We won't need anything from that. I'm almost done with firmware support. The
> only thing you'll need to do is to copy the .cod file(s) into /lib/firmware
> or wherever your firmware loader (probably udev nowadays) finds such files.
>
> Could you post me lspci -vvxxx output of your moxa card?
>
> thanks,
> --js
Ah, I see, you want to get rid of moxaload altogether ...
I'll test your patch series as soon as I get a chance - need to put a
MOXA card into a non-production machine first, so it'll be a few days.
We have a few MOXA Intellio C320 Turbo PCI
cards, here's lspci -vvxxx for one of them:
02:02.0 Serial controller: Moxa Technologies Co Ltd Intellio C320 Turbo PCI (rev 02) (prog-if 80)
Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Interrupt: pin A routed to IRQ 16
Region 1: I/O ports at 9400 [size=128]
Region 2: Memory at fb200000 (32-bit, non-prefetchable) [size=16K]
00: 93 13 00 32 03 00 80 02 02 80 00 07 08 00 00 00
10: 00 00 00 00 01 94 00 00 00 00 20 fb 00 00 00 00
20: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
30: 00 00 00 00 00 00 00 00 00 00 00 00 0b 01 00 00
40: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
60: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
The other cards looks identical, except for unimportant differences
in region mapping and IRQ allocation due to system differences.
Øyvind.
**************************************************************************
* Øyvind Aabling E-mail : Oyvind.Aabling@uni-c.dk /~\ The ASCII *
* UNI-C Lyngby Phone : +45 35 87 88 89 \ / Ribbon *
* DTU Building 304 Phone : +45 35 87 89 51 (direct) X Campaign *
* DK-2800 LYNGBY Fax : +45 35 87 89 90 / \ Against *
* Denmark HTML Email! *
**************************************************************************
next prev parent reply other threads:[~2008-01-24 23:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.0801202145230.18101@dbs1.uni-c.dtu.dk>
2008-01-21 22:51 ` [PATCH] drivers/char/moxa.c, kernel 2.6.23.14 Jiri Slaby
2008-01-22 10:23 ` Oyvind Aabling
2008-01-23 15:37 ` Jiri Slaby
2008-01-24 23:34 ` Oyvind Aabling [this message]
2008-01-24 23:38 ` Jiri Slaby
2008-01-24 9:32 ` [RFC 1/5] Char: moxa, remove static isa support Jiri Slaby
2008-01-24 9:32 ` [RFC 2/5] Char: moxa, cleanup module-param passed isa init Jiri Slaby
2008-01-24 9:32 ` [RFC 3/5] Char: moxa, pci io space fixup Jiri Slaby
2008-01-24 9:32 ` [RFC 4/5] Char: moxa, fix TIOC(G/S)SOFTCAR param Jiri Slaby
2008-01-24 9:32 ` [RFC 5/5] Char: moxa, add firmware loading Jiri Slaby
2008-01-27 19:16 ` [RFC 1/6] " Jiri Slaby
2008-01-27 19:16 ` [RFC 2/6] Char: moxa, merge c2xx and c320 " Jiri Slaby
2008-01-27 19:16 ` [RFC 3/6] Char: moxa, remove port->port Jiri Slaby
2008-01-27 19:16 ` [RFC 4/6] Char: moxa, remove unused port entries Jiri Slaby
2008-01-27 19:16 ` [RFC 5/6] Char: moxa, centralize board readiness Jiri Slaby
2008-01-27 19:16 ` [RFC 6/6] Char: moxa, timer cleanup Jiri Slaby
2008-01-21 12:35 [PATCH] drivers/char/moxa.c, kernel 2.6.23.14 Oyvind Aabling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0801250013410.3424@dbs1.uni-c.dtu.dk \
--to=oyvind.aabling@uni-c.dk \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).