From: Mike Isely <isely@isely.net>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Michael Krufky <mkrufky@linuxtv.org>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Guennadi Liakhovetski <g.liakhovetski@pengutronix.de>
Subject: Re: [patch] video: build fix for drivers/media/video/pvrusb2/
Date: Tue, 13 May 2008 10:56:20 -0500 (CDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0805131050210.20885@cnc.isely.net> (raw)
In-Reply-To: <20080513124630.111c465b@gaivota>
On Tue, 13 May 2008, Mauro Carvalho Chehab wrote:
> On Tue, 13 May 2008 00:03:02 -0400
> "Michael Krufky" <mkrufky@linuxtv.org> wrote:
>
> >
> > That sounds like it would be OK, although something like this would
> > probably be better:
> >
> > config VIDEO_PVRUSB2
> > tristate "Hauppauge WinTV-PVR USB2 support"
> > - depends on VIDEO_V4L2 && I2C
> > + depends on VIDEO_V4L2 && I2C && (DVB_CORE if VIDEO_PVRUSB2_DVB)
> > select FW_LOADER
> > select MEDIA_TUNER
> > select VIDEO_TVEEPROM
>
> This doesn't look to be a good idea, since VIDEO_PVRUSB2_DVB depends on
> VIDEO_PVRUSB2. So, you'll create a circular dependency. The syntax I've
> proposed seems cleaner. Of course, it needs to be tested. IMO, all hybrid
> devices should be dependent of VIDEO_MEDIA. This will help to avoid this kind
> of issue.
>
> > I don't know if that syntax works for "depends on" , but it does work
> > for select.
> >
> > if "depends on FOO if BAR" doesnt work, would adding "select DVB_CORE
> > if VIDEO_PVRUSB2_DVB" solve the problem?
>
> Also, this leads into a circular reference.
Mauro:
Where is the loop that results in a circular reference? No part of V4L
or DVB depends (or otherwise has any reliance) on VIDEO_PVRUSB2. All
Mike Krufky is trying to set up is that VIDEO_PVRUSB2 should only depend
on DVB_CORE if the DVB part of the driver (i.e. VIDEO_PVRUSB2_DVB) has
been enabled. Without VIDEO_PVRUSB2_DVB selected, then DVB_CORE is not
required by the driver.
I've been quiet about this issue because I'm not a kconfig expert, but
you've lost me with this conclusion.
-Mike
--
Mike Isely
isely @ pobox (dot) com
PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8
next prev parent reply other threads:[~2008-05-13 15:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-11 7:21 [patch] video: build fix for drivers/media/video/pvrusb2/ Ingo Molnar
2008-05-11 12:34 ` Michael Krufky
2008-05-13 2:54 ` Mauro Carvalho Chehab
2008-05-13 4:03 ` Michael Krufky
2008-05-13 15:46 ` Mauro Carvalho Chehab
2008-05-13 15:54 ` mkrufky
2008-05-13 16:30 ` mkrufky
2008-05-13 15:56 ` Mike Isely [this message]
2008-05-13 16:02 ` Mike Isely
2008-05-14 6:01 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0805131050210.20885@cnc.isely.net \
--to=isely@isely.net \
--cc=g.liakhovetski@pengutronix.de \
--cc=isely@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mingo@elte.hu \
--cc=mkrufky@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).