From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Luotao Fu <l.fu@pengutronix.de>
Cc: video4linux-list@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove duplicated defines in pxa_camera.c
Date: Mon, 5 Jan 2009 21:27:35 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0901052125480.8605@axis700.grange> (raw)
In-Reply-To: <1231175487-3293-1-git-send-email-l.fu@pengutronix.de>
On Mon, 5 Jan 2009, Luotao Fu wrote:
> Defines for CIR Registers have been moved to pxa_camera.h. So remove them from
> pxa_camera.c to avoid compiler warnings.
>
> Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
> ---
> drivers/media/video/pxa_camera.c | 13 -------------
> 1 files changed, 0 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/media/video/pxa_camera.c b/drivers/media/video/pxa_camera.c
> index cb8c5e1..4eda750 100644
> --- a/drivers/media/video/pxa_camera.c
> +++ b/drivers/media/video/pxa_camera.c
> @@ -44,19 +44,6 @@
> #define PXA_CAM_VERSION_CODE KERNEL_VERSION(0, 0, 5)
> #define PXA_CAM_DRV_NAME "pxa27x-camera"
>
> -/* Camera Interface */
> -#define CICR0 0x0000
> -#define CICR1 0x0004
> -#define CICR2 0x0008
> -#define CICR3 0x000C
> -#define CICR4 0x0010
> -#define CISR 0x0014
> -#define CIFR 0x0018
> -#define CITOR 0x001C
> -#define CIBR0 0x0028
> -#define CIBR1 0x0030
> -#define CIBR2 0x0038
> -
> #define CICR0_DMAEN (1 << 31) /* DMA request enable */
> #define CICR0_PAR_EN (1 << 30) /* Parity enable */
> #define CICR0_SL_CAP_EN (1 << 29) /* Capture enable for slave mode */
> --
> 1.5.6.5
NAK. Please, see an earlier patch from Eric Miao, a correct fix for this
is in the queue.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
next prev parent reply other threads:[~2009-01-05 20:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 17:11 [PATCH] remove duplicated defines in pxa_camera.c Luotao Fu
2009-01-05 20:27 ` Guennadi Liakhovetski [this message]
2009-01-05 20:43 ` Luotao Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0901052125480.8605@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=l.fu@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).