From: Sage Weil <sage@newdream.net>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kosaki.motohiro@gmail.com, rientjes@google.com,
Neil Brown <neilb@suse.de>,
Artem Bityutskiy <dedekind1@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
"Theodore Ts'o" <tytso@mit.edu>,
Adrian Hunter <adrian.hunter@intel.com>,
Steven Whitehouse <swhiteho@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
James Morris <jmorris@namei.org>,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] vmalloc: add warning in __vmalloc
Date: Wed, 2 May 2012 22:46:12 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.1205022241560.18540@cobra.newdream.net> (raw)
In-Reply-To: <4FA1D93C.9000306@kernel.org>
On Thu, 3 May 2012, Minchan Kim wrote:
> On 05/03/2012 04:46 AM, Andrew Morton wrote:
> > Well. What are we actually doing here? Causing the kernel to spew a
> > warning due to known-buggy callsites, so that users will report the
> > warnings, eventually goading maintainers into fixing their stuff.
> >
> > This isn't very efficient :(
>
>
> Yes. I hope maintainers fix it before merging this.
>
> >
> > It would be better to fix that stuff first, then add the warning to
> > prevent reoccurrences. Yes, maintainers are very naughty and probably
> > do need cattle prods^W^W warnings to motivate them to fix stuff, but we
> > should first make an effort to get these things fixed without
> > irritating and alarming our users.
> >
> > Where are these offending callsites?
Okay, maybe this is a stupid question, but: if an fs can't call vmalloc
with GFP_NOFS without risking deadlock, calling with GFP_KERNEL instead
doesn't fix anything (besides being more honest). This really means that
vmalloc is effectively off-limits for file systems in any
writeback-related path, right?
sage
>
>
> dm:
> __alloc_buffer_wait_no_callback
>
> ubi:
> ubi_dbg_check_write
> ubi_dbg_check_all_ff
>
> ext4 :
> ext4_kvmalloc
>
> gfs2 :
> gfs2_alloc_sort_buffer
>
> ntfs :
> __ntfs_malloc
>
> ubifs :
> dbg_dump_leb
> scan_check_cb
> dump_lpt_leb
> dbg_check_ltab_lnum
> dbg_scan_orphans
>
> mm :
> alloc_large_system_hash
>
> ceph :
> fill_inode
> ceph_setxattr
> ceph_removexattr
> ceph_x_build_authorizer
> ceph_decode_buffer
> ceph_alloc_middle
>
>
>
> >
> > --
> > To unsubscribe, send a message with 'unsubscribe linux-mm' in
> > the body to majordomo@kvack.org. For more info on Linux MM,
> > see: http://www.linux-mm.org/ .
> > Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
> > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
> >
>
>
>
> --
> Kind regards,
> Minchan Kim
>
>
next prev parent reply other threads:[~2012-05-03 5:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 4:28 [PATCH] vmalloc: add warning in __vmalloc Minchan Kim
2012-05-02 19:46 ` Andrew Morton
2012-05-03 1:02 ` Minchan Kim
2012-05-03 5:46 ` Sage Weil [this message]
2012-05-03 6:30 ` Nick Piggin
2012-05-03 7:13 ` Artem Bityutskiy
2012-05-03 7:14 ` Nick Piggin
2012-05-03 13:48 ` Steven Whitehouse
2012-05-03 5:55 ` Artem Bityutskiy
2012-05-03 11:11 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1205022241560.18540@cobra.newdream.net \
--to=sage@newdream.net \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jmorris@namei.org \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=neilb@suse.de \
--cc=rientjes@google.com \
--cc=swhiteho@redhat.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).