Re: [RFC PATCH 2/8] regulator: Add Dialog DA906x voltage regulators support.

From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Krystian Garbaciak <krystian.garbaciak@diasemi.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	linux-kernel@vger.kernel.org,
	Samuel Ortiz <sameo@linux.intel.com>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Jean Delvare <khali@linux-fr.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Richard Purdie <rpurdie@rpsys.net>,
	Anthony Olech <anthony.olech@diasemi.com>
Subject: Re: [RFC PATCH 2/8] regulator: Add Dialog DA906x voltage regulators support.
Date: Thu, 9 May 2013 16:05:44 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.1305091549300.22179@axis700.grange> (raw)
In-Reply-To: <201208311100@sw-eng-lt-dc-vm2>

(trimmed the CC a bit)

Hi Krystian

On Fri, 31 Aug 2012, Krystian Garbaciak wrote:

> > On Wed, Aug 29, 2012 at 03:50:00PM +0100, Krystian Garbaciak wrote:

Sorry for picking up a random mail from this old thread, unfortunately, I 
don't have "0/8" in my archive.

I have to write a driver for the da9063 PMIC. Do you have an idea, whether 
it'd be compatible with this driver? Do you plan to continue your work on 
this driver or would you mind if I try to use these your patches and 
mainline them, preserving your authorship and copyright, of course?

Thanks
Guennadi

> > > Because, for some regulators, this is required: val += fvol->offset,
> > > I was only able to reduce it to the following form.
> > 
> > What on earth makes you say this?  The above is obviously linear.
> > 
> > Besides, you're missing several points here.  One is that you should be
> > using the framework features, another is that you should be implementing
> > _sel.
> 
> Sorry, I've missed an obvious thing here. Instead of adding selector offset at
> runtime, I can substract apropriate voltage from .min_uV. Thanks for pointing
> this out.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/