linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
  • * Re: [PATCH 1/8] mfd: Add Dialog DA906x core driver.
           [not found] ` <201208241450@sw-eng-lt-dc-vm2>
           [not found]   ` <201208241455@sw-eng-lt-dc-vm2>
    @ 2012-08-25 18:31   ` Mark Brown
      2012-08-31 11:20     ` Krystian Garbaciak
      1 sibling, 1 reply; 13+ messages in thread
    From: Mark Brown @ 2012-08-25 18:31 UTC (permalink / raw)
      To: Krystian Garbaciak
      Cc: linux-kernel, rtc-linux, lm-sensors, linux-input, linux-watchdog,
    	linux-leds, Samuel Ortiz, Liam Girdwood, Alessandro Zummo,
    	Jean Delvare, Guenter Roeck, Dmitry Torokhov, Ashish Jangam,
    	Andrew Jones, Donggeun Kim, Philippe Rétornaz,
    	Wim Van Sebroeck, Bryan Wu,
    	Richard Purdie <rpurdie@rpsys.net> Anthony Olech
    
    On Fri, Aug 24, 2012 at 02:50:00PM +0100, Krystian Garbaciak wrote:
    
    > This is MFD module providing access to registers and interrupts of DA906x
    > series PMIC. It is used by other functional modules, registered as MFD cells.
    > Driver uses regmap with paging to access extended register list. Register map
    > is divided into two pages, where the second page is used during initialisation.
    
    Your selection of people to CC here appears both large and random...
    
    > +inline unsigned int da906x_to_range_reg(u16 reg)
    > +{
    > +	return reg + DA906X_MAPPING_BASE;
    > +}
    
    I've no real idea what this stuff is all about, it at least needs some
    comments somewhere.  The fact that you're just adding a constant offset
    to all registers is at best odd.
    
    > +	if (pdata->flags & DA906X_FLG_NO_CACHE)
    > +		config = &da906x_no_cache_regmap_config;
    
    No, why would anyone ever want this and why would this not apply to all
    other drivers?
    
    > +static const struct i2c_device_id da906x_i2c_id[] = {
    > +	{"da906x", PMIC_DA9063},
    > +	{},
    > +};
    > +MODULE_DEVICE_TABLE(i2c, da906x_i2c_id);
    
    List the actual devices here.
    
    > +#define DA906X_IRQ_BASE_OFFSET	0
    
    Hrm?
    
    ^ permalink raw reply	[flat|nested] 13+ messages in thread

  • end of thread, other threads:[~2013-05-09 14:50 UTC | newest]
    
    Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
    -- links below jump to the message on this page --
         [not found] <201208241445@sw-eng-lt-dc-vm2>
         [not found] ` <201208241450@sw-eng-lt-dc-vm2>
         [not found]   ` <201208241455@sw-eng-lt-dc-vm2>
    2012-08-25 15:10     ` [RFC PATCH 2/8] regulator: Add Dialog DA906x voltage regulators support Mark Brown
    2012-08-29 14:50       ` Krystian Garbaciak
    2012-08-30 17:47         ` Mark Brown
    2012-08-31 10:00           ` Krystian Garbaciak
    2013-05-09 14:05             ` Guennadi Liakhovetski
    2013-05-09 14:18               ` Anthony Olech
    2013-05-09 14:28                 ` Guennadi Liakhovetski
    2013-05-09 14:42                   ` Anthony Olech
    2013-05-09 14:50                     ` Guennadi Liakhovetski
    2012-08-25 18:31   ` [PATCH 1/8] mfd: Add Dialog DA906x core driver Mark Brown
    2012-08-31 11:20     ` Krystian Garbaciak
    2012-08-31 11:37       ` Philippe Rétornaz
    2012-08-31 17:16       ` Mark Brown
    

    This is a public inbox, see mirroring instructions
    for how to clone and mirror all data and code used for this inbox;
    as well as URLs for NNTP newsgroup(s).