From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751361Ab3FWN0r (ORCPT ); Sun, 23 Jun 2013 09:26:47 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:57878 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944Ab3FWN0l (ORCPT ); Sun, 23 Jun 2013 09:26:41 -0400 Date: Sun, 23 Jun 2013 15:26:10 +0200 (CEST) From: Guennadi Liakhovetski X-X-Sender: lyakh@axis700.grange To: Prabhakar Lad cc: Mauro Carvalho Chehab , LMML , Hans Verkuil , Laurent Pinchart , DLOS , LKML , Hans Verkuil , Sakari Ailus Subject: Re: [PATCH] media: i2c: adv7343: add support for asynchronous probing In-Reply-To: <1371895657-2898-1-git-send-email-prabhakar.csengg@gmail.com> Message-ID: References: <1371895657-2898-1-git-send-email-prabhakar.csengg@gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Provags-ID: V02:K0:OKWpyLjgKY9C1NTkAr6RvaHbVYmdSJasLs09XyjbkWy 8Bk41SKjFqZwrGTUfJ7/PMiEvocEedecWRbWW/AIf83ItuxFI2 XAEggJyWvNuLItP5abIuJCg7jsJjeltLPZeBRPVlHRJkVuXrpn BQK/S6qqFZPaUJzmpUONmUEaTELZ44qkBeC8mPq0di/lG/W9iy b+Cv+2/kdRkX322VX5my2e0Le54qPNoi9jY+DgGId9Q/pljFmv q8Lve39Zr+D1yoMmGaBeben2iq7dmG3o08kYxH4Va4S77Esis/ nBZhSGuICSYivpkr2olU5aPNkgmOqhs/Sstten1vgrkbsV94DW vXWW+DP3iC7zPZ8AnY6MocG/b+wArN/VqkdE9pQJP/QJvjjM/4 ddxPjm5gWDtrA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 22 Jun 2013, Prabhakar Lad wrote: > From: "Lad, Prabhakar" > > Both synchronous and asynchronous adv7343 subdevice probing is supported by > this patch. > > Signed-off-by: Lad, Prabhakar > Cc: Guennadi Liakhovetski > Cc: Laurent Pinchart > Cc: Hans Verkuil > Cc: Sakari Ailus > Cc: Mauro Carvalho Chehab > --- > drivers/media/i2c/adv7343.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/i2c/adv7343.c b/drivers/media/i2c/adv7343.c > index 7606218..8080c2c 100644 > --- a/drivers/media/i2c/adv7343.c > +++ b/drivers/media/i2c/adv7343.c > @@ -27,6 +27,7 @@ > #include > > #include > +#include > #include > #include > > @@ -445,16 +446,21 @@ static int adv7343_probe(struct i2c_client *client, > ADV7343_GAIN_DEF); > state->sd.ctrl_handler = &state->hdl; > if (state->hdl.error) { > - int err = state->hdl.error; > - > - v4l2_ctrl_handler_free(&state->hdl); > - return err; > + err = state->hdl.error; > + goto done; What does this have to do with asynchronous probing? Please, remove. > } > v4l2_ctrl_handler_setup(&state->hdl); > > err = adv7343_initialize(&state->sd); > if (err) > + goto done; > + > + err = v4l2_async_register_subdev(&state->sd); > + > +done: This label won't be needed then either. Thanks Guennadi > + if (err < 0) > v4l2_ctrl_handler_free(&state->hdl); > + > return err; > } > > @@ -463,6 +469,7 @@ static int adv7343_remove(struct i2c_client *client) > struct v4l2_subdev *sd = i2c_get_clientdata(client); > struct adv7343_state *state = to_state(sd); > > + v4l2_async_unregister_subdev(&state->sd); > v4l2_device_unregister_subdev(sd); > v4l2_ctrl_handler_free(&state->hdl); > > -- > 1.7.9.5 > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/