From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751909AbcBURvP (ORCPT ); Sun, 21 Feb 2016 12:51:15 -0500 Received: from mout.gmx.net ([212.227.15.18]:55989 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751096AbcBURvM (ORCPT ); Sun, 21 Feb 2016 12:51:12 -0500 Date: Sun, 21 Feb 2016 17:04:00 +0100 (CET) From: Guennadi Liakhovetski X-X-Sender: lyakh@axis700.grange To: Andrzej Hajda cc: linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz , Marek Szyprowski , Ludovic Desroches , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: Re: [PATCH 4/7] atmel-isi: fix IS_ERR_VALUE usage In-Reply-To: <1455546925-22119-5-git-send-email-a.hajda@samsung.com> Message-ID: References: <1455546925-22119-1-git-send-email-a.hajda@samsung.com> <1455546925-22119-5-git-send-email-a.hajda@samsung.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Provags-ID: V03:K0:mrttx2BzbhDAgVt29dsLArQo2swrsA7gnYQg7V5EZC5dthaIV1n bdQlihzjciiZY5jKKfDcwoxRFAeFhoiw7DD1aiU4/NEL+6/TkNWaCn95TYU3nVvSi4RsPBZ q2em48I2NgP5gLejSDW2ZkMfcIaEo065N6heXBcwb2ObgRhiOW2QNkJWl7wKqHkKBWaa2Dt YnvRJGFrT+vM1itsbflgw== X-UI-Out-Filterresults: notjunk:1;V01:K0:ErbRfBIcuV8=:iBpPFd40nn+vcLTuzRpFlX 9ABygK7bdGWFhdzHhTkDf72Lc5vfVs5qD+/tfsNwyU+DsLpOJJdn4fU/5tjqsYz09xCXzTM6Y OpeDun+gB1RZhlZ+jy7FmkD8xMLpe4wbZ09zYtKefV1U5+UYIPooVSNXLRRKjVuRcso1dK9bp MmjYMXDmzg6JDPBQZztHmPMv8VCOSqixUyqFjFNlnWNv3s4JslDWSCU9Abn35fUOdT6q1T0Px mL25O02oa+NTUfT76fUgZhKsTDoN05kCfwzcQ/MYDXEKyw/M4H6XPIwUCTs2ZntExmO55ciJR ioT7Au7dXBxM0YEz9Hu5oZJ7NCkLXijHQwZojYYSPnA0K6wWFq1zXSZ/KxRra2hs0tfVHD6Oy KRW6kzm9tg8maZdDEGwOQP1IzwdsCGOCiIalmaWgstmB5U0AsJKIqGo1543f9UGAaSXtF6R8t GU4tCBjoQ/nYcghwZsAwpAxNiDlHS75V8DplfkyyoDUourQxd9DJf9JFhpmxcLwUkzGa5MEwA GO4zHijjnBsO1nqjbMe1Z1Rbm2lQtPzXESnQZRonv3WGBhCXfzJrOXufFLh93V9W43PChqjbT OJegfB6cdtwWZRTQVLrj15COPMuGizPtQRY7z70/djyWzHQy6klNIb4C4uejm5gfgVO5XCpcW XixnvknXSOyPwkiDmN06WUR0ti0aR1RDMOdYVj/wMyVjztiwBDIi9KmTatCoYih4nl52yudmX qAdaojS168wDU8llzFQi1kdmmVZKmjwMdPwSKMHCTqqPmiXvjrgLBUGXmUN0xQe+lssq8YyFx DB8jhlV Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrzej, On Mon, 15 Feb 2016, Andrzej Hajda wrote: > IS_ERR_VALUE macro should be used only with unsigned long type. > For signed types comparison 'ret < 0' should be used. > > The patch follows conclusion from discussion on LKML [1][2]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2120927 > [2]: http://permalink.gmane.org/gmane.linux.kernel/2150581 > > Signed-off-by: Andrzej Hajda Thanks for the patch, but this one https://lkml.org/lkml/2016/2/9/392 came a couple of days earlier. Unless there is an important reason to use yours, I'll use that one. Thanks Guennadi > --- > drivers/media/platform/soc_camera/atmel-isi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi.c > index 1af779e..ab2d9b9 100644 > --- a/drivers/media/platform/soc_camera/atmel-isi.c > +++ b/drivers/media/platform/soc_camera/atmel-isi.c > @@ -1026,7 +1026,7 @@ static int atmel_isi_parse_dt(struct atmel_isi *isi, > > static int atmel_isi_probe(struct platform_device *pdev) > { > - unsigned int irq; > + int irq; > struct atmel_isi *isi; > struct resource *regs; > int ret, i; > @@ -1086,7 +1086,7 @@ static int atmel_isi_probe(struct platform_device *pdev) > isi->width_flags |= 1 << 9; > > irq = platform_get_irq(pdev, 0); > - if (IS_ERR_VALUE(irq)) { > + if (irq < 0) { > ret = irq; > goto err_req_irq; > } > -- > 1.9.1 >