From: David Rientjes <rientjes@cs.washington.edu>
To: "Ahmed S. Darwish" <darwish.07@gmail.com>
Cc: alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.20-rc3] TTY_IO code cleanups
Date: Fri, 5 Jan 2007 16:00:36 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64N.0701051559080.27059@attu4.cs.washington.edu> (raw)
In-Reply-To: <20070105235604.GA24091@Ahmed>
On Sat, 6 Jan 2007, Ahmed S. Darwish wrote:
> @@ -791,17 +790,15 @@ static int tty_ldisc_try(struct tty_struct *tty)
> {
> unsigned long flags;
> struct tty_ldisc *ld;
> - int ret = 0;
>
> spin_lock_irqsave(&tty_ldisc_lock, flags);
> ld = &tty->ldisc;
> - if(test_bit(TTY_LDISC, &tty->flags))
> - {
> + if(test_bit(TTY_LDISC, &tty->flags)) {
> ld->refcount++;
> - ret = 1;
> + return 1;
> }
> spin_unlock_irqrestore(&tty_ldisc_lock, flags);
> - return ret;
> + return 0;
> }
>
> /**
You leave tty_ldisk_lock locked.
next prev parent reply other threads:[~2007-01-06 0:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-05 23:56 [PATCH 2.6.20-rc3] TTY_IO code cleanups Ahmed S. Darwish
2007-01-06 0:00 ` David Rientjes [this message]
2007-01-06 14:38 ` Jan Engelhardt
2007-01-06 0:08 Ahmed S. Darwish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64N.0701051559080.27059@attu4.cs.washington.edu \
--to=rientjes@cs.washington.edu \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=darwish.07@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).