From: Adrian Bunk <bunk@fs.tum.de>
To: Linus Torvalds <torvalds@transmeta.com>,
John Stultz <johnstul@us.ibm.com>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux v2.5.42
Date: Sat, 12 Oct 2002 07:53:43 +0200 (CEST) [thread overview]
Message-ID: <Pine.NEB.4.44.0210120746530.8340-100000@mimas.fachschaften.tu-muenchen.de> (raw)
In-Reply-To: <Pine.LNX.4.44.0210112134160.7166-100000@penguin.transmeta.com>
On Fri, 11 Oct 2002, Linus Torvalds wrote:
>...
> Summary of changes from v2.5.41 to v2.5.42
> ============================================
>...
> John Stultz <johnstul@us.ibm.com>:
>...
> o linux-2.5.41_timer-changes_A4 (2/3 - bulk move)
>...
This patch moved cpufreq stuff from time.c to timers/timer_tsc.c but not
the corresponding #include <linux/cpufreq.h> causing the following compile
error:
<-- snip -->
...
gcc -Wp,-MD,arch/i386/kernel/timers/.timer_tsc.o.d -D__KERNEL__
-Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer
-fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=k6
-Iarch/i386/mach-generic -nostdinc -iwithprefix include -DKBUILD_BASENAME=timer_tsc -c -o
arch/i386/kernel/timers/timer_tsc.o arch/i386/kernel/timers/timer_tsc.c
arch/i386/kernel/timers/timer_tsc.c: In function `time_cpufreq_notifier':
arch/i386/kernel/timers/timer_tsc.c:181: `CPUFREQ_PRECHANGE' undeclared
...
arch/i386/kernel/timers/timer_tsc.c:183: `CPUFREQ_ALL_CPUS' undeclared
...
arch/i386/kernel/timers/timer_tsc.c:192: `CPUFREQ_POSTCHANGE' undeclared
...
arch/i386/kernel/timers/timer_tsc.c:265: `CPUFREQ_TRANSITION_NOTIFIER' undeclared
...
make[2]: *** [arch/i386/kernel/timers/timer_tsc.o] Error 1
<-- snip -->
The fix is simple:
--- linux-2.5.42-full/arch/i386/kernel/time.c.old 2002-10-12 07:43:55.000000000 +0200
+++ linux-2.5.42-full/arch/i386/kernel/time.c 2002-10-12 07:44:05.000000000 +0200
@@ -43,7 +43,6 @@
#include <linux/smp.h>
#include <linux/module.h>
#include <linux/device.h>
-#include <linux/cpufreq.h>
#include <asm/io.h>
#include <asm/smp.h>
--- linux-2.5.42-full/arch/i386/kernel/timers/timer_tsc.c.old 2002-10-12 07:40:26.000000000 +0200
+++ linux-2.5.42-full/arch/i386/kernel/timers/timer_tsc.c 2002-10-12 07:44:25.000000000 +0200
@@ -7,6 +7,7 @@
#include <linux/init.h>
#include <linux/timex.h>
#include <linux/errno.h>
+#include <linux/cpufreq.h>
#include <asm/timer.h>
#include <asm/io.h>
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2002-10-12 5:47 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-12 4:59 Linux v2.5.42 Linus Torvalds
2002-10-12 5:53 ` Adrian Bunk [this message]
2002-10-12 7:23 ` Adrian Bunk
2002-10-12 7:52 ` Andres Salomon
2002-10-12 9:23 ` David S. Miller
2002-10-12 9:11 ` Adrian Bunk
2002-10-12 9:24 ` Adrian Bunk
2002-10-12 9:41 ` Sam Ravnborg
2002-10-12 10:21 ` Adrian Bunk
2002-10-12 9:50 ` Matthias Andree
2002-10-12 11:11 ` jw schultz
2002-10-12 11:29 ` Andres Salomon
2002-10-12 11:46 ` Alan Cox
2002-10-12 11:40 ` jw schultz
2002-10-12 17:47 ` Jon Portnoy
2002-10-12 18:10 ` Rik van Riel
2002-10-13 11:58 ` venom
2002-10-13 12:52 ` Michael Clark
2002-10-12 12:37 ` Ed Tomlinson
2002-10-12 13:32 ` Christoph Hellwig
2002-10-12 19:39 ` Andres Salomon
2002-10-12 13:43 ` Christoph Hellwig
2002-10-13 17:10 ` Dipankar Sarma
2002-10-14 10:01 ` Joe Thornber
2002-10-14 19:21 ` Christoph Hellwig
2002-10-14 19:32 ` Alexander Viro
2002-10-14 22:28 ` Joe Thornber
2002-10-12 17:14 Mark Peloquin
2002-10-12 19:34 ` Alan Cox
2002-10-12 19:37 ` jbradford
2002-10-13 23:55 ` Rob Landley
2002-10-13 12:41 ` [Evms-devel] " Michael Clark
2002-10-13 13:49 ` Christoph Hellwig
2002-10-13 15:16 ` Michael Clark
2002-10-13 15:35 ` Christoph Hellwig
2002-10-13 16:11 ` Brian Jackson
2002-10-13 16:26 ` Arjan van de Ven
2002-10-13 17:06 ` Brian Jackson
2002-10-13 19:58 ` Mark Hahn
2002-10-13 19:57 ` Rik van Riel
2002-10-13 20:26 ` Sean Neakums
2002-10-24 11:45 ` Alexander Kellett
2002-10-13 19:59 ` Andrew Morton
2002-10-13 20:24 ` Bernd Eckenfels
2002-10-14 15:11 ` Christoph Hellwig
2002-10-14 22:27 ` Bernd Eckenfels
2002-10-13 17:46 ` Robert Love
2002-10-13 18:34 ` Brian Jackson
2002-10-14 14:45 ` Christoph Hellwig
2002-10-13 13:41 ` Christoph Hellwig
2002-10-12 20:20 Dieter Nützel
2002-10-12 22:19 ` Hans Reiser
2002-10-14 17:37 Ben Rafanello
2002-10-15 2:47 Paul McKenney
2002-10-15 17:43 Mark Peloquin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.NEB.4.44.0210120746530.8340-100000@mimas.fachschaften.tu-muenchen.de \
--to=bunk@fs.tum.de \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).