archive mirror
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <>
To: Marcelo Penna Guerra <>
Cc: Andre Hedrick <>, <>
Subject: Re: [PATCH] Merge the changes from siimage 2.4.22-pre9 to 2.6.0-test2
Date: Thu, 31 Jul 2003 17:25:37 +0200 (MET DST)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, 31 Jul 2003, Marcelo Penna Guerra wrote:

> Hi,


> I don't know if anyone is working on this, but I merged the changes from
> siimage 1.06 present in 2.4.x to 2.6.0-test2. I'm really not very familiar
> with the IDE code, so it's probably a good idea if someone could take a look
> at it. All I can tell is it's working with the SiI3112A present in my
> motherboard and it's a lot more stable than before.

Thanks, I'll take a look.

What do you mean by "a lot more stable than before"?

> I also added the suggestion from Andre to make the driver not care about cable
> detection and found a possible bug in the 2.4.x code.

Can you separate your changes from forward-port?

> In 2.4.22-pre9:
> if (!is_sata(hwif))
>        hwif->atapi_dma = 1;
> and DMA is not enabled by default.

This means that if this is a SATA controller DMA shouldn't be
enabled on ATAPI devices.  There are probably some reasons to do this.

> I think it should be:
> if (is_sata(hwif))
>        hwif->atapi_dma = 1;
> With this DMA is enabled by default on my board and works great.

Are you aware of side effect?
[ Disabling DMA on ATAPI devices on SiI680. ]

Please consult this change with Alan :-).

> Marcelo Penna Guerra


  reply	other threads:[~2003-07-31 15:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-31 17:49 [PATCH] Merge the changes from siimage 2.4.22-pre9 to 2.6.0-test2 Marcelo Penna Guerra
2003-07-31 15:25 ` Bartlomiej Zolnierkiewicz [this message]
2003-07-31 19:32   ` Marcelo Penna Guerra
2003-07-31 17:19     ` Alan Cox
2003-07-31 17:24     ` Bartlomiej Zolnierkiewicz
2003-08-02  8:29   ` Andre Hedrick
2003-07-31 15:58 ` Alan Cox
2003-08-07  9:49 CASINO_E
2003-08-07 12:29 ` Alan Cox
2003-08-07 13:35   ` Bartlomiej Zolnierkiewicz
2003-08-07 15:53     ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).