From: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: IDE locking problem
Date: Tue, 5 Aug 2003 02:28:10 +0200 (MET DST) [thread overview]
Message-ID: <Pine.SOL.4.30.0308050212540.16314-100000@mion.elka.pw.edu.pl> (raw)
In-Reply-To: <1059904692.3514.102.camel@gaston>
On 3 Aug 2003, Benjamin Herrenschmidt wrote:
> And there's more to it... ide_unregister() doesn't copy hwif->hold from
> old to new hwif causing my hotswap bay to lose it's iops on next plug,
> it doesn't call unregister_device() for neither hwif->gendev nor
> drive[n]->gendev, causing the device model list to be corrupted after
> an unregister, ...
What is a goal of calling init_hwif_data() in ide_unregister()?
I guess it is used mainly to clear hwif->io_ports and hwif->irq.
Therefore even if you are using hwif->hold flag io_ports will be set to
default values, so how do you later find your hwif?
Hmmm... what about not copying anything and calling init_hwif_data()
only if !hwif->hold?
--
Bartlomiej
next prev parent reply other threads:[~2003-08-05 0:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-03 8:42 IDE locking problem Benjamin Herrenschmidt
2003-08-03 9:58 ` Benjamin Herrenschmidt
2003-08-05 0:28 ` Bartlomiej Zolnierkiewicz [this message]
2003-08-05 8:08 ` Benjamin Herrenschmidt
2003-08-05 10:49 ` Bartlomiej Zolnierkiewicz
2003-08-05 11:18 ` Benjamin Herrenschmidt
2003-08-05 12:30 ` Bartlomiej Zolnierkiewicz
2003-08-05 17:13 ` Alan Cox
2003-08-03 10:04 ` Jens Axboe
2003-08-03 10:08 ` Jens Axboe
2003-08-03 10:11 ` Benjamin Herrenschmidt
2003-08-03 10:20 ` Jens Axboe
2003-08-03 14:13 Manfred Spraul
2003-08-03 14:25 ` Benjamin Herrenschmidt
2003-08-03 15:35 ` Lou Langholtz
2003-08-04 5:40 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.SOL.4.30.0308050212540.16314-100000@mion.elka.pw.edu.pl \
--to=b.zolnierkiewicz@elka.pw.edu.pl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).