From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45D95C4361B for ; Tue, 8 Dec 2020 15:39:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A40123A33 for ; Tue, 8 Dec 2020 15:39:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730013AbgLHPjM convert rfc822-to-8bit (ORCPT ); Tue, 8 Dec 2020 10:39:12 -0500 Received: from aposti.net ([89.234.176.197]:45206 "EHLO aposti.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729572AbgLHPjM (ORCPT ); Tue, 8 Dec 2020 10:39:12 -0500 Date: Tue, 08 Dec 2020 15:38:14 +0000 From: Paul Cercueil Subject: Re: [PATCH] mmc: mediatek: mark PM functions as __maybe_unused To: Arnd Bergmann Cc: Ulf Hansson , Chaotian Jing , Matthias Brugger , Wenbin Mei , Arnd Bergmann , Chun-Hung Wu , yong mao , Amey Narkhede , Marek Vasut , linux-mmc , Linux ARM , ARM/Mediatek SoC support , Linux Kernel Mailing List , "Rafael J. Wysocki" Message-Id: In-Reply-To: References: <20201203222922.1067522-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le mar. 8 déc. 2020 à 15:04, Arnd Bergmann a écrit : > On Mon, Dec 7, 2020 at 1:33 PM Paul Cercueil > wrote: >> Le ven. 4 déc. 2020 à 15:14, Arnd Bergmann a >> écrit > >> By the way, as I'm ending up doing the same in a different context, >> I >> think it would be useful to have a IF_ENABLED() macro defined like >> this: >> >> #define IF_ENABLED(_cfg, _ptr) (IS_ENABLED(_cfg) ? (_ptr) : NULL) >> >> Then the pm_ptr(_ptr) macro could be defined like this: >> >> #define pm_ptr(_ptr) IF_ENABLED(CONFIG_PM, _ptr) > > I like that. Do you just want to go ahead and start with adding > IF_ENABLED() to your own branch then? Sure. I'll send a patch later today and Cc you (and linux-arm?). Cheers, -Paul