From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7FC4C48BE8 for ; Wed, 16 Jun 2021 13:03:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DFB761356 for ; Wed, 16 Jun 2021 13:03:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233128AbhFPNFH (ORCPT ); Wed, 16 Jun 2021 09:05:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232223AbhFPNFF (ORCPT ); Wed, 16 Jun 2021 09:05:05 -0400 Received: from relay07.th.seeweb.it (relay07.th.seeweb.it [IPv6:2001:4b7a:2000:18::168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DF87C06175F for ; Wed, 16 Jun 2021 06:02:59 -0700 (PDT) Received: from [192.168.1.79] (bband-dyn73.178-41-129.t-com.sk [178.41.129.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id A5A8B3F31F; Wed, 16 Jun 2021 15:02:56 +0200 (CEST) Date: Wed, 16 Jun 2021 15:02:50 +0200 From: Martin Botka Subject: Re: [PATCH V3 2/2] arch: arm64: dts: qcom: Add support for Sony Xperia 10II To: Bjorn Andersson Cc: ~postmarketos/upstreaming@lists.sr.ht, konrad.dybcio@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, jamipkettunen@somainline.org, Andy Gross , Rob Herring , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck Message-Id: In-Reply-To: References: <20210613080522.25230-1-martin.botka@somainline.org> <20210613080522.25230-2-martin.botka@somainline.org> X-Mailer: geary/40.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 15 2021 at 07:31:43 PM -0500, Bjorn Andersson wrote: > On Sun 13 Jun 03:05 CDT 2021, Martin Botka wrote: > >> This commits add support for Sony Xperia 10II based on the SM6125 >> SoC. >> >> Currently working features: >> - dmesg output to bootloader preconfigured display >> - USB >> - eMMC >> - Volume down button >> >> Signed-off-by: Martin Botka >> --- >> Changes in v2, v3: >> None >> arch/arm64/boot/dts/qcom/Makefile | 1 + >> .../qcom/sm6125-sony-xperia-seine-pdx201.dts | 105 >> ++++++++++++++++++ >> 2 files changed, 106 insertions(+) >> create mode 100644 >> arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts >> >> diff --git a/arch/arm64/boot/dts/qcom/Makefile >> b/arch/arm64/boot/dts/qcom/Makefile >> index 456502aeee49..5a70dd9593c2 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile >> @@ -69,6 +69,7 @@ dtb-$(CONFIG_ARCH_QCOM) += >> sdm845-oneplus-enchilada.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sdm845-oneplus-fajita.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sdm845-xiaomi-beryllium.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sdm850-lenovo-yoga-c630.dtb >> +dtb-$(CONFIG_ARCH_QCOM) += sm6125-sony-xperia-seine-pdx201.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sm8150-hdk.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sm8150-mtp.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sm8250-hdk.dtb >> diff --git >> a/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts >> b/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts >> new file mode 100644 >> index 000000000000..b1d6de430273 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts >> @@ -0,0 +1,105 @@ >> +// SPDX-License-Identifier: BSD-3-Clause >> +/* >> + * Copyright (c) 2021, Martin Botka >> + */ >> + >> +/dts-v1/; >> + >> +#include "sm6125.dtsi" >> +#include >> +#include >> +#include >> + >> +/ { >> + /* required for bootloader to select correct board */ >> + qcom,msm-id = <394 0x10000>; /* sm6125 v1 */ >> + qcom,board-id = <34 0>; >> + >> + model = "Sony Xperia 10 II"; >> + compatible = "sony,pdx201", "qcom,sm6125"; >> + >> + chosen { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges; >> + >> + framebuffer0: framebuffer@5c000000 { >> + compatible = "simple-framebuffer"; >> + reg = <0 0x5c000000 0 (2520 * 1080 * 4)>; >> + width = <1080>; >> + height = <2520>; >> + stride = <(1080 * 4)>; >> + format = "a8r8g8b8"; >> + }; >> + }; >> + >> + extcon_usb: extcon-usb { >> + compatible = "linux,extcon-usb-gpio"; >> + id-gpio = <&tlmm 102 GPIO_ACTIVE_HIGH>; >> + }; >> + >> + gpio_keys { > > No '_' in node names, please go '-'. ack > >> + status = "okay"; >> + compatible = "gpio-keys"; >> + input-name = "gpio-keys"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + autorepeat; >> + >> + vol_dn { > > Ditto. ack > >> + label = "Volume Down"; >> + gpios = <&tlmm 47 GPIO_ACTIVE_LOW>; >> + linux,input-type = <1>; >> + linux,code = ; >> + gpio-key,wakeup; >> + debounce-interval = <15>; >> + }; >> + }; >> + > > Stray indentation on this line. My bad. Will remove. > > Thanks, > Bjorn > >> + reserved_memory { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + debug_mem: memory@ffb00000 { >> + reg = <0x0 0xffb00000 0x0 0xc0000>; >> + no-map; >> + }; >> + >> + last_log_mem: memory@ffbc0000 { >> + reg = <0x0 0xffbc0000 0x0 0x80000>; >> + no-map; >> + }; >> + >> + pstore_mem: ramoops@ffc00000 { >> + compatible = "ramoops"; >> + reg = <0x0 0xffc40000 0x0 0xc0000>; >> + record-size = <0x1000>; >> + console-size = <0x40000>; >> + msg-size = <0x20000 0x20000>; >> + }; >> + >> + cmdline_mem: memory@ffd00000 { >> + reg = <0x0 0xffd40000 0x0 0x1000>; >> + no-map; >> + }; >> + }; >> +}; >> + >> +&hsusb_phy1 { >> + status = "okay"; >> +}; >> + >> +&sdhc_1 { >> + status = "okay"; >> +}; >> + >> +&tlmm { >> + gpio-reserved-ranges = <22 2>, <28 6>; >> +}; >> + >> +&usb3 { >> + status = "okay"; >> +}; >> + >> +&usb3_dwc3 { >> + extcon = <&extcon_usb>; >> +}; >> -- >> 2.31.1 >>