From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 123B9C433E0 for ; Sun, 26 Jul 2020 16:12:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA602206D8 for ; Sun, 26 Jul 2020 16:12:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="VgHrj87M" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726738AbgGZQMk (ORCPT ); Sun, 26 Jul 2020 12:12:40 -0400 Received: from crapouillou.net ([89.234.176.41]:52544 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726044AbgGZQMj (ORCPT ); Sun, 26 Jul 2020 12:12:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1595779957; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1FFAOTmTlN9hjWJiCw3Kqkh+9m3EdO/XmQtlNexVKUk=; b=VgHrj87M4n7w13v3Yla8jb/IeH6VJn9SBxJnFV7HIX9qqehKWp1ggcfQlibif/zrFJYfmD WqdpYSHBhJn4QXbfOwMJcmVb9kDDAiWrvYWU7B90EK27fJHMb4BrT6hhTdd5hSaB57PwIf FF/uDBCSdYmh1Use/udSXAsJ0aIhmn0= Date: Sun, 26 Jul 2020 18:12:27 +0200 From: Paul Cercueil Subject: Re: [PATCH v3 2/2] mtd: rawnand: ingenic: Limit MTD_NAND_JZ4780 to architecture only To: Krzysztof Kozlowski Cc: Arnd Bergmann , Harvey Hunt , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-mtd Message-Id: In-Reply-To: <20200726160616.GA2662@kozik-lap> References: <20200724145401.2566-1-krzk@kernel.org> <20200724145401.2566-3-krzk@kernel.org> <20200724155436.GA7460@kozik-lap> <20200726160616.GA2662@kozik-lap> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le dim. 26 juil. 2020 =E0 18:06, Krzysztof Kozlowski a=20 =E9crit : > On Sat, Jul 25, 2020 at 08:30:56PM +0200, Arnd Bergmann wrote: >> On Sat, Jul 25, 2020 at 2:17 PM Paul Cercueil=20 >> wrote: >> > Le ven. 24 juil. 2020 =E0 17:54, Krzysztof Kozlowski=20 >> a >> > =E9crit : >> > > On Fri, Jul 24, 2020 at 05:50:06PM +0200, Paul Cercueil wrote: >> > >> Le ven. 24 juil. 2020 =E0 17:33, Krzysztof Kozlowski >> > >> a =E9crit: >> > >> > On Fri, 24 Jul 2020 at 17:19, Paul Cercueil=20 >> >> > >> > wrote: >> > >> >> > >> On MIPS, the SoC selection is a Kconfig "choice", so you can=20 >> only >> > >> support >> > >> one SoC family, unfortunately. >> > > >> > > Let's say someone selected then some other architecture >> > > (MIPS_ALCHEMY). >> > > They could select this MTD driver. >> > > >> > > Does it mean they would be able to run it on Ingenic hardware? >> > >> > In *theory* yes, as long as the Kconfig options that MACH_INGENIC >> > selects are enabled, the kernel should boot and work on Ingenic=20 >> SoCs. >>=20 >> Right now, this won't work yet, because there are platform specific >> functions that are implemented by each of the platforms in=20 >> arch/mips, >> e.g. arch/mips/generic/init.c and arch/mips/jz4740/setup.c. >=20 > I would say even more - no DTS would be provided for such=20 > configuration. > All Ingenic DTSes are included only with MACH_INGENIC. You cannot=20 > build > a kernel working on Ingenic without MACH_INGENIC. Even in theory. But the devicetree doesn't have to be built-in. -Paul >>=20 >> A lot of the newer platforms are part of arch/mips/generic >> (CONFIG_MIPS_GENERIC), which roughly corresponds to >> CONFIG_ARCH_MULTIPLATFORM on in arch/arm/. >> Similarly, there are header files in arch/mips/include/asm/mach-*/ >> that conflict and you need to have the right one. >>=20 >> To have more than one platform enabled, each one needs to >> have all of that platform code converted to fit into the >> MIPS_GENERIC framework. This can be a lot of work, but >> I suppose the ingenic platform would be a candidate for >> which this makes sense, as long as new SoCs of that family >> still come out. >=20 > I can therefore change the patch to: > depends on MACH_INGENIC || MIPS_GENERIC || COMPILE_TEST >=20 > Other solution is to leave MTD driver as is and for the memory driver=20 > go > with my v2 approach: > https://lore.kernel.org/lkml/20200724074038.5597-6-krzk@kernel.org/ >=20 > Best regards, > Krzysztof >=20