From: "Limonciello, Mario" <Mario.Limonciello@amd.com> To: Mark Brown <firstname.lastname@example.org> Cc: "email@example.com" <firstname.lastname@example.org>, "Mukunda, Vijendar" <Vijendar.Mukunda@amd.com>, "email@example.com" <firstname.lastname@example.org>, Liam Girdwood <email@example.com>, Jaroslav Kysela <firstname.lastname@example.org>, Takashi Iwai <email@example.com>, open list <firstname.lastname@example.org> Subject: RE: [PATCH v3 1/2] ASoC: amd: Don't show messages about deferred probing by default Date: Fri, 23 Jul 2021 13:04:51 +0000 [thread overview] Message-ID: <SA0PR12MB45103F60E23D6BE8CF7E603DE2E59@SA0PR12MB4510.namprd12.prod.outlook.com> (raw) In-Reply-To: <20210723123847.GB5221@sirena.org.uk> [Public] > > On Thu, Jul 22, 2021 at 08:27:27AM -0500, Mario Limonciello wrote: > > > This isn't useful to a user, especially as probing will run again. > > Use the dev_err_probe helper to hide the deferrerd probing messages. > > The reason we have these error messages is that they are very useful to > users if they ever find that the device isn't instantiating due to some > missing dependency or something that leaves it stuck in probe deferral, > they give some hint as to what might be wrong. Right, but they should be at debugging level, if someone has a problem they turn on dynamic debugging for the module and then can see these messages. To reinforce my point - that's what the drivers in patch 2/2 do already (but are being moved to this helper) and furthermore this was in result to some reports looking at this message in bootup thinking it was a problem but it being a red herring.
next prev parent reply other threads:[~2021-07-23 13:04 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-22 13:27 Mario Limonciello 2021-07-22 13:27 ` [PATCH v3 2/2] ASoC: amd: Use dev_probe_err helper Mario Limonciello 2021-07-23 12:38 ` [PATCH v3 1/2] ASoC: amd: Don't show messages about deferred probing by default Mark Brown 2021-07-23 13:04 ` Limonciello, Mario [this message] 2021-07-23 14:00 ` Mark Brown 2021-07-23 17:01 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=SA0PR12MB45103F60E23D6BE8CF7E603DE2E59@SA0PR12MB4510.namprd12.prod.outlook.com \ --email@example.com \ --cc=Vijendar.Mukunda@amd.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='RE: [PATCH v3 1/2] ASoC: amd: Don'\''t show messages about deferred probing by default' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).