From: "Li, Xin3" <xin3.li@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"brgerst@gmail.com" <brgerst@gmail.com>,
"Bae, Chang Seok" <chang.seok.bae@intel.com>,
"Gross, Jurgen" <jgross@suse.com>
Subject: RE: [PATCH v5 5/5] x86/gsseg: use the LKGS instruction if available for load_gs_index()
Date: Wed, 11 Jan 2023 18:22:37 +0000 [thread overview]
Message-ID: <SA1PR11MB67342AB67CC1EA0654762488A8FC9@SA1PR11MB6734.namprd11.prod.outlook.com> (raw)
In-Reply-To: <Y77H+rThnJixLEQC@zn.tnic>
> > The LKGS instruction atomically loads a segment descriptor into the
> > %gs descriptor registers, *except* that %gs.base is unchanged, and the
> > base is instead loaded into MSR_IA32_KERNEL_GS_BASE, which is exactly
> > what we want this function to do.
> >
> > Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > Signed-off-by: Brian Gerst <brgerst@gmail.com>
> > Signed-off-by: Juergen Gross <jgross@suse.com>
> > Signed-off-by: Xin Li <xin3.li@intel.com>
>
> I'm reading this SOB chain as
>
> hpa wrote it -> then it went to Peter -> then to Brian -> then to Juergen -> and
> you're sending it.
>
> I'm pretty sure that cannot be right.
>
> > ---
> >
> > Changes since v4:
> > * Clear the LKGS feature from Xen PV guests (Juergen Gross).
> >
> > Changes since v3:
> > * We want less ASM not more, thus keep local_irq_save/restore() inside
> > native_load_gs_index() (Thomas Gleixner).
> > * For paravirt enabled kernels, initialize pv_ops.cpu.load_gs_index to
> > native_lkgs (Thomas Gleixner).
> >
> > Changes since v2:
> > * Mark DI as input and output (+D) as in V1, since the exception handler
> > modifies it (Brian Gerst).
> >
> > Changes since v1:
> > * Use EX_TYPE_ZERO_REG instead of fixup code in the obsolete .fixup code
> > section (Peter Zijlstra).
> > * Add a comment that states the LKGS_DI macro will be repalced with "lkgs
> %di"
> > once the binutils support the LKGS instruction (Peter Zijlstra).
>
> I guess that explains what the SOB chain is supposed to mean - you've gotten
> review feedback. But that doesn't need such a SOB chain. Sounds like you need
> to refresh on
Your guess is correct, will remove those SOBs in v6.
> Documentation/process/submitting-patches.rst
>
> Thx.
>
> --
> Regards/Gruss,
> Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2023-01-11 18:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 16:40 [PATCH v5 0/5] x86: Enable LKGS instruction Xin Li
2022-11-28 16:40 ` [PATCH v5 1/5] x86/cpufeature: add the cpu feature bit for LKGS Xin Li
2023-01-11 14:27 ` Borislav Petkov
2023-01-11 18:18 ` Li, Xin3
2022-11-28 16:40 ` [PATCH v5 2/5] x86/opcode: add the LKGS instruction to x86-opcode-map Xin Li
2022-11-28 16:40 ` [PATCH v5 3/5] x86/gsseg: make asm_load_gs_index() take an u16 Xin Li
2022-11-28 16:40 ` [PATCH v5 4/5] x86/gsseg: move load_gs_index() to its own new header file Xin Li
2022-11-28 16:40 ` [PATCH v5 5/5] x86/gsseg: use the LKGS instruction if available for load_gs_index() Xin Li
2023-01-11 14:30 ` Borislav Petkov
2023-01-11 18:22 ` Li, Xin3 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA1PR11MB67342AB67CC1EA0654762488A8FC9@SA1PR11MB6734.namprd11.prod.outlook.com \
--to=xin3.li@intel.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=chang.seok.bae@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).